Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Missing a few devices. #16

Open
ethanwa opened this issue Nov 4, 2017 · 1 comment
Open

Missing a few devices. #16

ethanwa opened this issue Nov 4, 2017 · 1 comment

Comments

@ethanwa
Copy link

ethanwa commented Nov 4, 2017

Consider adding these, because more and more devices can have apps like the Apple TV, Watch, and possibly HomePod and beyond:

if ([platform isEqualToString:@"iPhone3,2"]) return @"iPhone 4 (GSM, Rev A)";
if ([platform isEqualToString:@"AppleTV2,1"]) return @"Apple TV (2nd Gen)";
if ([platform isEqualToString:@"AppleTV3,1"]) return @"Apple TV (3rd Gen)";
if ([platform isEqualToString:@"AppleTV3,2"]) return @"Apple TV (3rd Gen)";
if ([platform isEqualToString:@"AppleTV5,3"]) return @"Apple TV (4th Gen)";
if ([platform isEqualToString:@"AppleTV6,2"]) return @"Apple TV 4K";
if ([platform isEqualToString:@"Watch1,1"]) return @"Apple Watch (1st Gen, 38mm)";
if ([platform isEqualToString:@"Watch1,2"]) return @"Apple Watch (1st Gen, 42mm)";
if ([platform isEqualToString:@"Watch2,3"]) return @"Apple Watch Series 2 (38mm)";
if ([platform isEqualToString:@"Watch2,4"]) return @"Apple Watch Series 2 (42mm)";
if ([platform isEqualToString:@"Watch2,6"]) return @"Apple Watch Series 1 (38mm)";
if ([platform isEqualToString:@"Watch2,7"]) return @"Apple Watch Series 1 (42mm)";
if ([platform isEqualToString:@"Watch3,1"]) return @"Apple Watch Series 3 (Cellular, 38mm)";
if ([platform isEqualToString:@"Watch3,2"]) return @"Apple Watch Series 3 (Cellular, 42mm)";
if ([platform isEqualToString:@"Watch3,3"]) return @"Apple Watch Series 3 (GPS, 38mm)";
if ([platform isEqualToString:@"Watch3,4"]) return @"Apple Watch Series 3 (GPS, 42mm)";
if ([platform isEqualToString:@"AirPods1,1"]) return @"AirPods";
if ([platform isEqualToString:@"AudioAccessory1,1"]) return @"HomePod";

And changing to these so that we can see which cell type the device has:

if ([platform isEqualToString:@"iPhone9,1"]) return @"iPhone 7 (Global)";
if ([platform isEqualToString:@"iPhone9,2"]) return @"iPhone 7 Plus (Global)";
if ([platform isEqualToString:@"iPhone9,3"]) return @"iPhone 7 (GSM)";
if ([platform isEqualToString:@"iPhone9,4"]) return @"iPhone 7 Plus (GSM)";
if ([platform isEqualToString:@"iPhone10,1"]) return @"iPhone 8 (Global)";
if ([platform isEqualToString:@"iPhone10,2"]) return @"iPhone 8 Plus (Global)";
if ([platform isEqualToString:@"iPhone10,3"]) return @"iPhone X (Global)";
if ([platform isEqualToString:@"iPhone10,4"]) return @"iPhone 8 (GSM)";
if ([platform isEqualToString:@"iPhone10,5"]) return @"iPhone 8 Plus (GSM)";
if ([platform isEqualToString:@"iPhone10,6"]) return @"iPhone X (GSM)";

@fahrulazmi
Copy link
Owner

Can you submit a PR please 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants