Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory access issue in x86 Windows Vista #1

Open
fafalone opened this issue Mar 11, 2023 · 0 comments
Open

Potential memory access issue in x86 Windows Vista #1

fafalone opened this issue Mar 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@fafalone
Copy link
Owner

fafalone commented Mar 11, 2023

The RTL_USER_PROCESS_PARAMETERS structure has it's last member as EnvironmentSize As LongLong, this is incorrect as it should be LongPtr (ULONG_PTR). This is less of an issue on Win7+ because 7 contains an additional LongPtr member at that location, so the only issue is the value of the last parameter rather than overrunning the structure.

If this is an issue for you, change EnvironmentSize to LongPtr, until the next version is published.

Some member names are also incorrect but indicate the same thing (e.g. StdInputHandle instead of StandardInput).

@fafalone fafalone added the bug Something isn't working label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant