Passwords are corrupted on paste

[grahamc]

On macOS using iTerm2 and Ghostty, input is corrupted and the rendering is bad when pasting a long password into the Password prompt with 0.3.5, like this:

fn main() {
    // input super long input:
    /*
    foooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooobar
        */
    // you will not see the "bar" at the end
    let s = cliclack::password("password pls")
        .mask('*')
        .interact()
        .unwrap();

    dbg!(&s);
}

When pasting a real token, the data is not just truncated -- but corrupted. See this screenshot, which shows the tail end of a token, where the correct next character is 3 but a T is received:

Samples of the handling on different terminals:

Ghostty:

iTerm2:

Terminal.app is fine:

[grahamc]

Unfortunately, it looks like the console crate puts the terminal into raw mode on each character read, so there is no safe, race-free way to do this. The crossterm crate handles this more correctly by explicitly going in to raw mode for the entire prompt read process. Fwiw, requestty appears to correctly use the raw mode feature to make pasting long passwords race-free.

[fadeevab]

Tbh, transitioning to crossterm probably would be the best ultimate solution, but it needs a decent amount of work and testing.

[fadeevab]

@grahamc It seems like an old console's issue: console-rs/console#152. It happens on certain terminals: iTerm2 and VSCode terminal.

I tried a naive way of switching to crossterm, but it requires manual handling of screen scrolling behaviour (e.g. when the cursor reaches the bottom of a terminal). console is just a nice compromise: rendering in a usual mode, while reading keys in a raw mode.

For cliclack, one dirty workaround might be using a console::Term::read_line_secretly() for the Password prompt. It may need passing a flag right into a common interaction trait. Literally, poking a "hole in the abstraction"