Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

generate_questions produces a dataset that is more balanced than the original one #19

Open
rizar opened this issue Aug 6, 2019 · 4 comments

Comments

@rizar
Copy link

rizar commented Aug 6, 2019

There must be another discrepancy between generate_questions.py and the original script that was used to generate CLEVR. I have noticed that in CLEVR the answer distribution for counting questions is very skewed. For example, for one of the question families I have the following answer counts:

{'1': 2658, '0': 2555, '2': 1911, '5': 52, '3': 579, '6': 17, '4': 136, '7': 2, '9': 1}

Here the 6th popular answer is "6" with the count of 17. This could not have happened if the current version of generate_questions.py were used, since it has a heuristic that forces all answer to occur at most 5 times as often as the 6th popular answer:

https://github.com/facebookresearch/clevr-dataset-gen/blob/master/question_generation/generate_questions.py#L322

The main reason I have created this here is for the record, because it's unclear how this issue can be addressed. But I guess people who are using the code should be made aware.

@jcjohnson
Copy link

You are correct -- thanks for pointing this out!

For generating the official released CLEVR data, we distributed question generation across multiple machines (using these flags) and merged the results. This means that the heuristics were only applied within the batch processed by each worker, and not enforced across the entire dataset. I suspect that this is the reason for the differing distributions that you are seeing.

@rizar
Copy link
Author

rizar commented Aug 16, 2019

Ok, thanks for confirming!

@yonatansverdlov
Copy link

Hi Justin @jcjohnson.
I am working on the CLEVR dataset.
I am not sure how to decide the right of a given Object as sometimes pixel coordinates don't make sense and sometimes 3D_coords don't make sense.

@pudumagico
Copy link

hi @yonatansverdlov, did you find out which to use? I am also confused...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants