PosixMmapReadableFile::Read and PosixRandomAccessFile::Read has different behavior #12925
Comments
rockeet
added a commit
to topling/toplingdb
that referenced
this issue
Aug 9, 2024
The behavior of PosixMmapReadableFile::Read and PosixRandomAccessFile::Read should be same. see facebook/rocksdb#12925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
The behavior of
PosixMmapReadableFile::ReadandPosixRandomAccessFile::Readshould be same.Actual behavior
When the param
offsetis beyound file size, PosixMmapReadableFile::Read returns IOError but PosixRandomAccessFile::Read returns OK.Steps to reproduce the behavior
Create a PosixMmapReadableFile and a PosixRandomAccessFile, write same content, then read beyound file size.
The fix should be simple, the key is which behavior is expected. This issue was found in our branch while we add PosixMmapReadableFile to
env_basic_test.cc.The text was updated successfully, but these errors were encountered: