Skip to content

fix[devtools]: still show overlay, if getClientRects is not implemented #35294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoxyq wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −6
Open

fix[devtools]: still show overlay, if getClientRects is not implemented #35294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions packages/react-devtools-shared/src/backend/views/Highlighter/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,12 @@ export default function setupHighlighter(
typeof node.getClientRects === 'function'
? node.getClientRects()
: [];
// If this is currently display: none, then try another node.
// This can happen when one of the host instances is a hoistable.
if (
nodeRects.length > 0 &&
(nodeRects.length > 2 ||
nodeRects[0].width > 0 ||
nodeRects[0].height > 0)
typeof node.getClientRects === 'undefined' || // If Host doesn't implement getClientRects, try to show the overlay.
(nodeRects.length > 0 && // If this is currently display: none, then try another node.
(nodeRects.length > 2 || // This can happen when one of the host instances is a hoistable.
nodeRects[0].width > 0 ||
nodeRects[0].height > 0))
) {
// $FlowFixMe[method-unbinding]
if (scrollIntoView && typeof node.scrollIntoView === 'function') {
Expand Down
Loading