Rename values of TracingState enum (#54630)

Summary:
Pull Request resolved: #54630

# Changelog: [Internal]

Readability.

Reviewed By: cortinico

Differential Revision: D87123903

fbshipit-source-id: b4c2bac73616b0884c97f1d894232608b6b016d9

Author: hoxyq

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgelessDevSupportManager.kt

@@ -83,6 +83,6 @@ internal class BridgelessDevSupportManager(
   }
 
   fun tracingState(): TracingState {
-    return TracingState.ENABLEDINCDPMODE
+    return TracingState.ENABLED_IN_CDP_MODE
   }
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.kt

@@ -399,21 +399,21 @@ public abstract class DevSupportManagerBase(
 
       val analyzePerformanceItemString =
           when (tracingState) {
-            TracingState.ENABLEDINBACKGROUNDMODE ->
+            TracingState.ENABLED_IN_BACKGROUND_MODE ->
                 applicationContext.getString(R.string.catalyst_performance_background)
-            TracingState.ENABLEDINCDPMODE ->
+            TracingState.ENABLED_IN_CDP_MODE ->
                 applicationContext.getString(R.string.catalyst_performance_cdp)
             TracingState.DISABLED ->
                 applicationContext.getString(R.string.catalyst_performance_disabled)
           }
 
-      if (!isConnected || tracingState == TracingState.ENABLEDINCDPMODE) {
+      if (!isConnected || tracingState == TracingState.ENABLED_IN_CDP_MODE) {
         disabledItemKeys.add(analyzePerformanceItemString)
       }
 
       options[analyzePerformanceItemString] =
           when (tracingState) {
-            TracingState.ENABLEDINBACKGROUNDMODE ->
+            TracingState.ENABLED_IN_BACKGROUND_MODE ->
                 DevOptionHandler {
                   UiThreadUtil.runOnUiThread {
                     if (reactInstanceDevHelper is PerfMonitorDevHelper) {
@@ -430,7 +430,7 @@ public abstract class DevSupportManagerBase(
                   if (reactInstanceDevHelper is PerfMonitorDevHelper)
                       reactInstanceDevHelper.inspectorTarget?.resumeBackgroundTrace()
                 }
-            TracingState.ENABLEDINCDPMODE -> DevOptionHandler {}
+            TracingState.ENABLED_IN_CDP_MODE -> DevOptionHandler {}
           }
     }
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/TracingState.kt

@@ -12,6 +12,6 @@ import com.facebook.proguard.annotations.DoNotStripAny
 @DoNotStripAny
 internal enum class TracingState {
   DISABLED, // There is no active trace
-  ENABLEDINBACKGROUNDMODE, // Trace is currently running in background mode
-  ENABLEDINCDPMODE, // Trace is currently running in CDP mode
+  ENABLED_IN_BACKGROUND_MODE, // Trace is currently running in background mode
+  ENABLED_IN_CDP_MODE, // Trace is currently running in CDP mode
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayManager.kt

@@ -23,7 +23,7 @@ internal class PerfMonitorOverlayManager(
     get() = enabled
 
   private var view: PerfMonitorOverlayView? = null
-  private var tracingState: TracingState = TracingState.ENABLEDINCDPMODE
+  private var tracingState: TracingState = TracingState.ENABLED_IN_CDP_MODE
   private var perfIssueCount: Int = 0
   private val handler = Handler(Looper.getMainLooper())
 
@@ -109,7 +109,7 @@ internal class PerfMonitorOverlayManager(
 
   private fun handleRecordingButtonPress() {
     when (tracingState) {
-      TracingState.ENABLEDINBACKGROUNDMODE -> {
+      TracingState.ENABLED_IN_BACKGROUND_MODE -> {
         devHelper.inspectorTarget?.let { target ->
           if (!target.pauseAndAnalyzeBackgroundTrace()) {
             onRequestOpenDevTools()
@@ -119,7 +119,7 @@ internal class PerfMonitorOverlayManager(
       TracingState.DISABLED -> {
         devHelper.inspectorTarget?.resumeBackgroundTrace()
       }
-      TracingState.ENABLEDINCDPMODE -> Unit
+      TracingState.ENABLED_IN_CDP_MODE -> Unit
     }
   }
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayView.kt

@@ -50,12 +50,12 @@ internal class PerfMonitorOverlayView(
   }
 
   fun updateRecordingState(state: TracingState) {
-    if (state == TracingState.ENABLEDINCDPMODE) {
+    if (state == TracingState.ENABLED_IN_CDP_MODE) {
       dialog.hide()
       return
     }
 
-    if (state == TracingState.ENABLEDINBACKGROUNDMODE) {
+    if (state == TracingState.ENABLED_IN_BACKGROUND_MODE) {
       (statusIndicator.background as GradientDrawable).setColor(Color.RED)
       statusLabel.text = "Profiling Active"
       tooltipLabel.text =

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImplDevHelper.kt

@@ -81,6 +81,6 @@ internal class ReactHostImplDevHelper(private val delegate: ReactHostImpl) :
       delegate.loadBundle(bundleLoader)
 
   override fun getTracingState(): TracingState {
-    return delegate.reactHostInspectorTarget?.getTracingState() ?: TracingState.ENABLEDINCDPMODE
+    return delegate.reactHostInspectorTarget?.getTracingState() ?: TracingState.ENABLED_IN_CDP_MODE
   }
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostInspectorTarget.kt

@@ -64,7 +64,7 @@ internal class ReactHostInspectorTarget(reactHostImpl: ReactHostImpl) :
   override fun resumeBackgroundTrace() {
     startBackgroundTrace()
     perfMonitorListeners.forEach { listener ->
-      listener.onRecordingStateChanged(TracingState.ENABLEDINBACKGROUNDMODE)
+      listener.onRecordingStateChanged(TracingState.ENABLED_IN_BACKGROUND_MODE)
     }
   }
 

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.cpp

@@ -33,11 +33,11 @@ jni::local_ref<JTracingState::javaobject> convertCPPTracingStateToJava(
     case TracingState::EnabledInBackgroundMode:
       return valueOfMethod(
           tracingStateClass,
-          jni::make_jstring("ENABLEDINBACKGROUNDMODE").get());
+          jni::make_jstring("ENABLED_IN_BACKGROUND_MODE").get());
 
     case TracingState::EnabledInCDPMode:
       return valueOfMethod(
-          tracingStateClass, jni::make_jstring("ENABLEDINCDPMODE").get());
+          tracingStateClass, jni::make_jstring("ENABLED_IN_CDP_MODE").get());
 
     default:
       jni::throwNewJavaException(