Skip to content

Commit a2e8bac

Browse files
fabriziocuccimeta-codesync[bot]
authored andcommitted
Flip default value for shouldResetClickableWhenRecyclingView (#54649)
Summary: Pull Request resolved: #54649 Changelog: [Android][Fixed] - Enabled shouldResetClickableWhenRecyclingView by default to reset isClickable to false when recycling views and prevent accessibility tools from detecting incorrect clickable states. Reviewed By: cortinico Differential Revision: D87778143 fbshipit-source-id: b88a6d73e15b228945d5788d5c06657b2626ab00
1 parent adc0934 commit a2e8bac

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<cfdeb7b6ddf02d0eebd04d6fe55d4775>>
7+
* @generated SignedSource<<c7c15289a7da56ef403691768489b6f6>>
88
*/
99

1010
/**
@@ -163,7 +163,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
163163

164164
override fun shouldPressibilityUseW3CPointerEventsForHover(): Boolean = false
165165

166-
override fun shouldResetClickableWhenRecyclingView(): Boolean = false
166+
override fun shouldResetClickableWhenRecyclingView(): Boolean = true
167167

168168
override fun shouldResetOnClickListenerWhenRecyclingView(): Boolean = false
169169

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<a50549b6884d7f4671d5167cd4cb38f2>>
7+
* @generated SignedSource<<14228fac25bcaaf06f437b5805ef04ce>>
88
*/
99

1010
/**
@@ -308,7 +308,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
308308
}
309309

310310
bool shouldResetClickableWhenRecyclingView() override {
311-
return false;
311+
return true;
312312
}
313313

314314
bool shouldResetOnClickListenerWhenRecyclingView() override {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,7 @@ const definitions: FeatureFlagDefinitions = {
796796
ossReleaseStage: 'none',
797797
},
798798
shouldResetClickableWhenRecyclingView: {
799-
defaultValue: false,
799+
defaultValue: true,
800800
metadata: {
801801
description:
802802
'Reset isClickable to false when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling.',

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<3e75c668cf91189c87ccc330d5fc1800>>
7+
* @generated SignedSource<<0559a11a2edeec64fbc00451614e98d9>>
88
* @flow strict
99
* @noformat
1010
*/
@@ -512,7 +512,7 @@ export const shouldPressibilityUseW3CPointerEventsForHover: Getter<boolean> = cr
512512
/**
513513
* Reset isClickable to false when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling.
514514
*/
515-
export const shouldResetClickableWhenRecyclingView: Getter<boolean> = createNativeFlagGetter('shouldResetClickableWhenRecyclingView', false);
515+
export const shouldResetClickableWhenRecyclingView: Getter<boolean> = createNativeFlagGetter('shouldResetClickableWhenRecyclingView', true);
516516
/**
517517
* Reset OnClickListener to null when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling.
518518
*/

0 commit comments

Comments
 (0)