make the default debugger-shell spawn command unset ELECTRON_RUN_AS_NODE (#54654)

Summary:

make the default debugger-shell spawn command unset ELECTRON_RUN_AS_NODE

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D86673603

Author: vzaidman

packages/debugger-shell/src/node/index.flow.js

@@ -51,6 +51,13 @@ async function unstable_spawnDebuggerShellWithArgs(
       stdio: 'inherit',
       windowsHide: true,
       detached: mode === 'detached',
+      env: {
+        ...process.env,
+        // If this package is used in an Electron app (e.g. inside a VS Code extension),
+        // ELECTRON_RUN_AS_NODE=1 can leak from the parent process.
+        // Since this is never the right way to launch the Fusebox shell, we guard against it here.
+        ELECTRON_RUN_AS_NODE: '',
+      },
     });
     if (mode === 'detached') {
       child.on('spawn', () => {