Skip to content

Commit 4631a6d

Browse files
authored
feat(timeline): display newly supported options for Timeline (#224)
1 parent 7f25433 commit 4631a6d

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

front_end/panels/timeline/TimelinePanel.ts

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
573573
this.panelToolbar.wrappable = true;
574574
this.panelRightToolbar = timelineToolbarContainer.createChild('devtools-toolbar');
575575
this.panelRightToolbar.role = 'presentation';
576-
if (!isNode && !isReactNative) {
576+
if (!isNode) {
577577
this.createSettingsPane();
578578
this.updateShowSettingsToolbarButton();
579579
}
@@ -1225,7 +1225,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
12251225
}
12261226

12271227
// Settings
1228-
if (!isNode && !isReactNative) {
1228+
if (!isNode) {
12291229
this.panelRightToolbar.appendSeparator();
12301230
this.panelRightToolbar.appendToolbarItem(this.showSettingsPaneButton);
12311231
}
@@ -1334,22 +1334,24 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
13341334
this.disableCaptureJSProfileSetting.title(), this.disableCaptureJSProfileSetting,
13351335
i18nString(UIStrings.disablesJavascriptSampling)));
13361336

1337-
const cpuThrottlingPane = this.settingsPane.createChild('div');
1338-
cpuThrottlingPane.append(i18nString(UIStrings.cpu));
1339-
this.cpuThrottlingSelect = MobileThrottling.ThrottlingManager.throttlingManager().createCPUThrottlingSelector();
1340-
cpuThrottlingPane.append(this.cpuThrottlingSelect.control.element);
1337+
if (!isReactNative) {
1338+
const cpuThrottlingPane = this.settingsPane.createChild('div');
1339+
cpuThrottlingPane.append(i18nString(UIStrings.cpu));
1340+
this.cpuThrottlingSelect = MobileThrottling.ThrottlingManager.throttlingManager().createCPUThrottlingSelector();
1341+
cpuThrottlingPane.append(this.cpuThrottlingSelect.control.element);
13411342

1342-
this.settingsPane.append(UI.SettingsUI.createSettingCheckbox(
1343-
this.captureLayersAndPicturesSetting.title(), this.captureLayersAndPicturesSetting,
1344-
i18nString(UIStrings.capturesAdvancedPaint)));
1343+
this.settingsPane.append(UI.SettingsUI.createSettingCheckbox(
1344+
this.captureLayersAndPicturesSetting.title(), this.captureLayersAndPicturesSetting,
1345+
i18nString(UIStrings.capturesAdvancedPaint)));
13451346

1346-
const networkThrottlingPane = this.settingsPane.createChild('div');
1347-
networkThrottlingPane.append(i18nString(UIStrings.network));
1348-
networkThrottlingPane.append(this.createNetworkConditionsSelectToolbarItem().element);
1347+
const networkThrottlingPane = this.settingsPane.createChild('div');
1348+
networkThrottlingPane.append(i18nString(UIStrings.network));
1349+
networkThrottlingPane.append(this.createNetworkConditionsSelectToolbarItem().element);
13491350

1350-
this.settingsPane.append(UI.SettingsUI.createSettingCheckbox(
1351-
this.captureSelectorStatsSetting.title(), this.captureSelectorStatsSetting,
1352-
i18nString(UIStrings.capturesSelectorStats)));
1351+
this.settingsPane.append(UI.SettingsUI.createSettingCheckbox(
1352+
this.captureSelectorStatsSetting.title(), this.captureSelectorStatsSetting,
1353+
i18nString(UIStrings.capturesSelectorStats)));
1354+
}
13531355

13541356
const thirdPartyCheckbox =
13551357
this.createSettingCheckbox(this.#thirdPartyTracksSetting, i18nString(UIStrings.showDataAddedByExtensions));
@@ -1618,7 +1620,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
16181620
}
16191621

16201622
private updateSettingsPaneVisibility(): void {
1621-
if (isNode || isReactNative) {
1623+
if (isNode) {
16221624
return;
16231625
}
16241626
if (this.showSettingsPaneSetting.get()) {

0 commit comments

Comments
 (0)