From ad96a6eb7df3ae5ccc77772620f0ef01463c4b18 Mon Sep 17 00:00:00 2001 From: Ivor Zhou Date: Mon, 24 Aug 2026 19:01:00 -0700 Subject: [PATCH 1/2] docs(docsite): correct the backdropGlow comment's causal chain MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment said a fixed glow below 1024px 'blocked pull-to-refresh from ever registering a release'. It never did — `overscroll-behavior-y: none` in globals.css did. The glow is the *reason that rule was written*: it was the layer bleeding into the bottom-overscroll gap, and bounding it is what lets the rule scope to desktop widths. Comment only, no behavior change. Follow-up to #5415 (issue #5392). --- .../src/app/(site)/_landing/hero/HeroThemeReel.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx b/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx index 0390215cbccb3..9633c767b3718 100644 --- a/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx +++ b/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx @@ -175,9 +175,11 @@ const styles = stylex.create({ // Desktop: fixed, part of the pin-and-cover effect alongside heroContent // and the cards stage. Narrow: absolute within heroScope (position: // relative), so it scrolls away with the hero instead of staying pinned - // for the whole page — a fixed glow below 1024px reached past the - // footer into the bottom-overscroll gap, which blocked pull-to-refresh - // from ever registering a release (#5392). + // for the whole page — a fixed glow below 1024px reached past the footer + // into the bottom-overscroll gap. That exposure is what the app-global + // `overscroll-behavior-y: none` in globals.css was suppressing, at the + // cost of pull-to-refresh on every route on mobile; bounding the glow + // here is what lets that rule scope to desktop widths (#5392). position: { default: 'absolute', '@media (min-width: 1024px)': 'fixed', From 1c5f5fed6693ece072fb27eb9d57d045496dde47 Mon Sep 17 00:00:00 2001 From: Ivor Zhou Date: Tue, 25 Aug 2026 19:38:34 -0700 Subject: [PATCH 2/2] docs(docsite): drop the stale unconditional 'fixed' from the glow's header comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment directly above backdropGlow still described the layer as 'fixed' full stop. Since #5415 that is only true at >=1024px; below that it is absolute inside heroScope. Same defect class as the comment this branch already corrects, four lines away. Both siblings state the split — HeroFloatingCards' stage says 'Hidden <1024px', page.tsx's heroContent says 'Desktop: fixed ... Narrow: in flow' — so this was the one layer comment that hid its responsive behavior. Comment only, no behavior change. --- .../src/app/(site)/_landing/hero/HeroThemeReel.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx b/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx index 9633c767b3718..896939d6299ed 100644 --- a/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx +++ b/apps/docsite/src/app/(site)/_landing/hero/HeroThemeReel.tsx @@ -168,9 +168,11 @@ const styles = stylex.create({ transition: 'background-color 600ms ease', zIndex: 0, }, - // Blurred aurora glow — fixed, in the same 1200px box as the cards so blobs - // and cards stay aligned. Capped to 100vw to avoid horizontal scroll. Blob - // centers sit under the card clusters; colors come from --aurora-* per slide. + // Blurred aurora glow — in the same 1200px box as the cards so blobs and + // cards stay aligned; pinned at >=1024px and scrolling away with the hero + // below that (see `position`). Capped to 100vw to avoid horizontal scroll. + // Blob centers sit under the card clusters; colors come from --aurora-* per + // slide. backdropGlow: { // Desktop: fixed, part of the pin-and-cover effect alongside heroContent // and the cards stage. Narrow: absolute within heroScope (position: