Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce width of borders #1677

Open
RedAuburn opened this issue Jan 22, 2025 · 4 comments
Open

Reduce width of borders #1677

RedAuburn opened this issue Jan 22, 2025 · 4 comments
Labels
feature-mapstyle Issue or feature related to the styling and appearance of the map.

Comments

@RedAuburn
Copy link

This is a minor issue (and maybe only bothers me), but the thicker borders around polygons really bothers me in Rapid - they feel more 'clunky', and have a small downside of obscuring edges of stuff on imagery, although admittedly likely not enough to matter, and wireframe mode also exists.

In summary, these thicker borders just feel wrong to me, and this issue is more to discuss with the wider community :)

iD left / Rapid right

Image

@bhousel
Copy link
Contributor

bhousel commented Jan 22, 2025

In summary, these thicker borders just feel wrong to me, and this issue is more to discuss with the wider community :)

It is difficult for me to see the difference, but yes I guess Rapid's default stroke when drawing polygons is 2px and iD's is 1px. I don't remember changing this specifically, but I do think the Rapid one makes it a little easier to see where polygons are.

We could change the 2 to a 1 around these places to get them to look more the same, if people want this.

fill: { width: 2, color: 0xaaaaaa, alpha: 0.3 },

const lineWidth = isWireframeMode ? 1 : style.fill.width || 2;

@bhousel bhousel added the feature-mapstyle Issue or feature related to the styling and appearance of the map. label Jan 22, 2025
@Swarkin
Copy link

Swarkin commented Jan 22, 2025

I'd love to have thinner outlines whenever im editing densely mapped areas

@mxxcon
Copy link

mxxcon commented Jan 23, 2025

Can it visually be 1px but selection triggers on 2px width? I'm worried that with 1px everybody will have to be snipers with precise mouse movements to select what they're aiming for.

@bhousel
Copy link
Contributor

bhousel commented Jan 23, 2025

Can it visually be 1px but selection triggers on 2px width? I'm worried that with 1px everybody will have to be snipers with precise mouse movements to select what they're aiming for.

Yes, the hit area for the lines will still be a several-pixel-wide buffer around the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-mapstyle Issue or feature related to the styling and appearance of the map.
Projects
None yet
Development

No branches or pull requests

4 participants