Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove anything that looks like float or clearfix, replace with flexbox #1647

Open
bhousel opened this issue Dec 17, 2024 · 0 comments
Labels
chore Improvements to the code or development stack, cleanups feature-ui Issue or request related to the user interface design

Comments

@bhousel
Copy link
Contributor

bhousel commented Dec 17, 2024

At this point we should probably just search for and remove all instances of float: left or float: right or anything that looks like a clearfix hack. These cause a bunch of problems, and most of the UI is flexboxed now.

These are legacy css tricks for getting content to flow around other content. Flexbox has been a thing since even the IE9 days, so there probably aren't many of these vestigial css rules left in the Rapid code. It is worth it for me to search for them and remove them to avoid surprises like the one fixed by a0ed2ca.

Originally posted by @bhousel in a0ed2ca

@bhousel bhousel added chore Improvements to the code or development stack, cleanups feature-ui Issue or request related to the user interface design labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements to the code or development stack, cleanups feature-ui Issue or request related to the user interface design
Projects
None yet
Development

No branches or pull requests

1 participant