Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): Allow/Support Sequelize CLI migrations #48

Open
3 tasks
scott-wyatt opened this issue Jul 14, 2019 · 4 comments
Open
3 tasks

feat(): Allow/Support Sequelize CLI migrations #48

scott-wyatt opened this issue Jul 14, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@scott-wyatt
Copy link
Contributor

scott-wyatt commented Jul 14, 2019

Context:

Migration is one of the most important features for the lifecycle of an application. We should provide top notch support for https://sequelize.org/v5/manual/migrations.html. I don't really have a plan for the best way to do this, but we could use the config.sequelize to set the paths to the migrations and enable the CLI to work with the spool.

  • Should support Sequelize CLI
  • Should adjust based on Sequelize CLI migrations
  • Should handle seeds
@scott-wyatt scott-wyatt added enhancement New feature or request help wanted Extra attention is needed labels Jul 14, 2019
@jaumard
Copy link
Member

jaumard commented Oct 25, 2019

problem with sequelize migration is that it's mostly based on the use of the CLI for creating the models which we don't do in fabric.

Or do you have something else in mind ?

@scott-wyatt
Copy link
Contributor Author

So, I've been playing with this a little bit with the CLI, and it turns out, you can use a config for the CLI and point it where you want everything to happen. Probably at least need to find a good way of using the CLI and workin inside fabrix. Right now, the when migrate is turned on Fabrix, it's just calling model sync, which works about 65% of the time, and only for the current runtime environment.
I've been thinking about the Fab CLI here and allowing people to extend it just like they would fabrix, so that way any spool could also include it's fab CLI instructions and it would just work :-)

@jaumard
Copy link
Member

jaumard commented Oct 25, 2019

Is there a list of fab CLI commands ? Didn't even know there was one lool
But I like the idea of spool being able to extend it !
I'll try to dig a bit in sequelize migration see if I can understand better how it works ^^

@scott-wyatt
Copy link
Contributor Author

Awesome! There's this https://github.com/fabrix-app/fab-cli, and it's not fully working yet :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants