cracked project includes unrelated cs files from node_modules

[joprice]

Description

When taking a look at the project metadata in fable_modules/project_cracked.json, I found that some files like node_modules/node-gyp/lib/Find-VisualStudio.cs are mentioned in SourcePaths, without being included anywhere in the project. It seems there may be a glob for the fable_modules library that is unintentionally including fsharp files from node_modules. Not sure if this causes issues, but it seems incorrect. Perhaps there's a flag to suppress this? Not sure if it's intentional to pull in fsharp sources from npm dependencies.

Related information

• Fable version: 4.24.0
• Operating system: OSX

[MangelMaxime]

Does it also happens when passing --test:MSBuildCracker to Fable CLI ?

[joprice]

I flipped the flag and ran find . -name project_cracked_debug.json | xargs jq '.' | grep node_modules and it is definitely no longer happening with the MSBuildCracker 👍. If that's going to be the default in Fable 5, then no need to investigate.

[MangelMaxime]

Closing as MSBuildCracker is now the default in Fable 5