Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: the API reference is almost empty #209

Closed
kazizi55 opened this issue Oct 9, 2023 · 15 comments
Closed

docs: the API reference is almost empty #209

kazizi55 opened this issue Oct 9, 2023 · 15 comments
Assignees
Labels
documentation Improvements or additions to documentation priority This has priority

Comments

@kazizi55
Copy link
Contributor

kazizi55 commented Oct 9, 2023

Hi @fabian-hiller ,
if it’s not too much trouble for you, I'm willing to write the API reference together! 😄
How can I help you?
What's your plan to complete the API reference?

@fabian-hiller
Copy link
Owner

Thank you for creating this issue! Yes, I would appreciate support. If I manage to get a sponsor, I plan to give a part of it to people who support me with the docs.

My current plan is to create the first 1 to 3 API references myself and then get feedback from the community. Once we decide on a consistent format, this can be used as a template to write all further references.

Presumably the API references will be a mix of the docs of Zod and the API references of Modular Forms.

@fabian-hiller fabian-hiller self-assigned this Oct 9, 2023
@fabian-hiller fabian-hiller added documentation Improvements or additions to documentation priority This has priority labels Oct 9, 2023
@kazizi55
Copy link
Contributor Author

@fabian-hiller

I would appreciate support.

So happy to hear that!

If I manage to get a sponsor, I plan to give a part of it to people who support me with the docs.

Wow, wonderful 😄

My current plan is to create the first 1 to 3 API references myself and then get feedback from the community.

Since you seem so busy, may I create the first 1 to 3 API references? 😄

Presumably the API references will be a mix of the docs of Zod and the API references of Modular Forms.

Sounds good!

@fabian-hiller
Copy link
Owner

fabian-hiller commented Oct 10, 2023

Great! Feel free to create a first draft of the string API reference (e.g. as a draft PR) and share your ideas there. We can also work together on this. The goal is to have a first-class API reference by the time we reach v1.

@kazizi55
Copy link
Contributor Author

@fabian-hiller
OK! I'm gonna create the draft of string API in the coming days!

@danielo515
Copy link

So, just to be clear, there are no docs currently for the API ? The link to the API reference points to Any, which is confusing, will be better to have a specific message

@fabian-hiller
Copy link
Owner

@danielo515 on the left (or bottom on mobile) on our website you can navigate to the different APIs and use the link to the source code on GitHub for now. The code is simple and well documented. Otherwise you can also use TypeBox-Workbench to convert a TypeScript type to Valibot.

We start working on the API reference on our website shortly.

@danielo515
Copy link

danielo515 commented Oct 19, 2023 via email

@fabian-hiller
Copy link
Owner

any is just the first page (the first API) of our API reference.

@fabian-hiller
Copy link
Owner

@kazizi55 have you started a first draft? If not, I might start working on a draft this weekend. For a faster exchange, feel free to connect with me on Discord (fabianhiller).

@kazizi55
Copy link
Contributor Author

@fabian-hiller
Sorry for my late reply and a first draft 🙇

have you started a first draft?

Yes, I've started a first draft, and maybe will finish making a draft this weekend!

For a faster exchange, feel free to connect with me on Discord (fabianhiller).

Thanks! I'll connect!

@wout-junius
Copy link
Contributor

I am willing to help with the docs as well since I am missing them a lot xD
I'll wait till @kazizi55 PR gets trough to see an example and then I might be able to continue as well ;)

@fabian-hiller
Copy link
Owner

Thank you @wout-junius! That's means a lot to me. Yes, once the first draft is ready it can be used as an template to add all the other references.

@wout-junius
Copy link
Contributor

So since the first PR for docs has been merged, how do we divide or decide wich pages are done by whom?

@fabian-hiller
Copy link
Owner

I think the best way is to create a new issue where everyone can add a comment that I will summeries at the top of the issue to prevent two people working on the same reference. What do you think about this? Do you have a better idea?

@fabian-hiller
Copy link
Owner

I created #287 to coordinate the expansion of our API reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority This has priority
Projects
None yet
Development

No branches or pull requests

4 participants