Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot tests embed unpinned package versions #330

Closed
Ilia-Kosenkov opened this issue Jan 2, 2024 · 1 comment · Fixed by #334
Closed

Snapshot tests embed unpinned package versions #330

Ilia-Kosenkov opened this issue Jan 2, 2024 · 1 comment · Fixed by #334
Labels
bug Something isn't working

Comments

@Ilia-Kosenkov
Copy link
Member

Check this output of failed CIs. Snapshot functions have transform parameter, which is a function applied to snapshot text. You can use regex to match versions and replace them with placeholders to make snapshots deterministic.

image

https://github.com/extendr/rextendr/actions/runs/7359908400
@Ilia-Kosenkov Ilia-Kosenkov added the bug Something isn't working label Jan 2, 2024
@Ilia-Kosenkov
Copy link
Member Author

@JosiahParry , cannot assign you directly yet, so just pinging.

@Ilia-Kosenkov Ilia-Kosenkov mentioned this issue Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix snapshot tests Ilia-Kosenkov/rextendr
1 participant
@Ilia-Kosenkov