Merge pull request #196 from expobrain/remove_bidirectional_unused_argument

Removed bidirectional keyword and simplified code

Author: expobrain

sqlalchemy_to_json_schema/schema_factory.py

@@ -212,9 +212,8 @@ def overrides(self, basedict: dict[str, Any], /) -> None:
 
 
 class ChildFactory:
-    def __init__(self, *, splitter: str = ".", bidirectional: bool = False) -> None:
+    def __init__(self, *, splitter: str = ".") -> None:
         self.splitter = splitter
-        self.bidirectional = bidirectional
 
     def default_excludes(self, prop: MapperProperty, /) -> list[str]:
         nullable_excludes = [
@@ -243,12 +242,13 @@ def child_walker(
         history: Any | None = None,
     ) -> AbstractWalker:
         name = prop.key
+        includes = get_children(name, walker.includes, splitter=self.splitter)
         excludes = get_children(name, walker.includes, splitter=self.splitter, default=[])
-        if not self.bidirectional:
-            if excludes is None:
-                raise RuntimeError("excludes is None")
+
+        if excludes is None:
+            excludes = self.default_excludes(prop)
+        else:
             excludes.extend(self.default_excludes(prop))
-        includes = get_children(name, walker.includes, splitter=self.splitter)
 
         return walker.clone(
             name,

tests/test_relation.py

@@ -9,11 +9,7 @@
 from sqlalchemy.orm import Mapped, declarative_base
 
 from sqlalchemy_to_json_schema.decisions import UseForeignKeyIfPossibleDecision
-from sqlalchemy_to_json_schema.schema_factory import (
-    ChildFactory,
-    RelationDecision,
-    SchemaFactory,
-)
+from sqlalchemy_to_json_schema.schema_factory import RelationDecision, SchemaFactory
 from sqlalchemy_to_json_schema.walkers import (
     AbstractWalker,
     ForeignKeyWalker,
@@ -102,27 +98,6 @@ def test_properties__include_ManytoOne_backref() -> None:
     }
 
 
-def test_properties__include_ManytoOne_backref__bidirectional_is_true() -> None:
-    target = _makeOne(StructuralWalker, child_factory=ChildFactory(bidirectional=True))
-    result = target(Group)
-
-    assert "required" in result
-    assert list(sorted(result["properties"])) == ["name", "pk", "users"]
-    assert result["properties"]["users"] == {
-        "type": "array",
-        "items": {"$ref": "#/definitions/User"},
-    }
-    assert result["definitions"]["User"] == {
-        "type": "object",
-        "required": ["pk"],
-        "properties": {
-            "name": {"maxLength": 255, "type": "string"},
-            "group": {"$ref": "#/definitions/Group"},
-            "pk": {"description": "primary key", "type": "integer"},
-        },
-    }
-
-
 # depth
 class A0(Base):
     __tablename__ = "A0"