Disable public IP check

[checktext00]

Describe the bug
Stats sometimes tries to connect to api.mac-stats.com on TCP port 443 even when "Check for updates" is set to "Never" and "Share anonymous telemetry" is disabled in Settings

Details:

• macOS: 11
• Application version: 2.11.30

[exelban]

you need to disable public ip

[checktext00]

you need to disable public ip

it's already disabled, in Network > "Auto-refresh public IP address" is set to "Never" (which is already the default)

[exelban]

hmm, it's only when Stats starts or with some interval when running?

[checktext00]

It seem to happen whenever I connect to a VPN using Tunnelblick, right when the VPN connection succeeds Stats tries to connect. I also reset all the settings to default (with "Check for updates" set to "Never" and "Share anonymous telemetry" disabled) for testing and Stats still does this

[exelban]

ok, now I see. It's because network status has changed. And Stats recheck the public IP when network does down/up.

Will take a look if I have time to add an option to fully block that. Since it's needed only for very specific users that for 100% can block all requests via little snitch or any other tool. I'm not sure for users like this it's needed since their already block all requests, so it's pretty useless.

[checktext00]

I updated from 2.11.30 to 2.11.32 and the behavior now occurs on every launch of Stats instead of just when connecting to a VPN (I again reset all settings with "Check for updates" set to "Never" and "Share anonymous telemetry" disabled)

Also, a separate but related issue is that on a first-time launch Stats tries to connect to both api.mac-stats.com and api.github.com on the "Welcome to Stats" setup screen, before the user has made any choice about checking for updates or sharing telemetry data (tested on Stats 2.11.32)