Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Chromatic on correct ref, require approval before running pull_request_target actions #2722

Merged
merged 20 commits into from
Nov 5, 2024
Merged

Run Chromatic on correct ref, require approval before running pull_request_target actions #2722

merged 20 commits into from
Nov 5, 2024

Conversation

zachstence
Copy link
Member

@zachstence zachstence commented Nov 4, 2024 •
edited
Loading

Fixes #2720

@zachstence zachstence self-assigned this Nov 4, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:17pm
next-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 5:17pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bb53553

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit bb53553
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/672a85c1841d7600084ea856
😎 Deploy Preview https://deploy-preview-2722--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

❌ Deploy Preview for evidence-development-workspace failed. Why did it fail? →

Name Link
🔨 Latest commit bb53553
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/672a85c156798400080d9794

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2024 •
edited
Loading

✅ Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 0441fb9
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/672a52fd6632eb0008b9c854
😎 Deploy Preview https://deploy-preview-2722--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zachstence zachstence force-pushed the ci/fix-chromatic-trigger branch from ba967d7 to 6a3f241 Compare November 4, 2024 22:52
@zachstence zachstence temporarily deployed to Approval required to run action on external PR November 4, 2024 23:04 — with GitHub Actions Inactive
@zachstence zachstence temporarily deployed to Approval required to run action on external PR November 4, 2024 23:06 — with GitHub Actions Inactive
@zachstence zachstence temporarily deployed to Approval required to run action on external PR November 4, 2024 23:08 — with GitHub Actions Inactive
@zachstence zachstence force-pushed the ci/fix-chromatic-trigger branch from febb129 to bcf5ee4 Compare November 4, 2024 23:26
@zachstence zachstence changed the title ci: set-environment reusable workflow Run Chromatic on correct ref, require approval before running pull_request_target actions Nov 4, 2024
@zachstence zachstence temporarily deployed to Approval required to run action on external PR November 5, 2024 17:08 — with GitHub Actions Inactive
@zachstence zachstence force-pushed the ci/fix-chromatic-trigger branch from fb2d01e to 0441fb9 Compare November 5, 2024 17:16
@zachstence zachstence marked this pull request as ready for review November 5, 2024 17:16
@zachstence zachstence merged commit af75508 into next Nov 5, 2024
15 of 18 checks passed
@zachstence zachstence deleted the ci/fix-chromatic-trigger branch November 5, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsMeBrianD ItsMeBrianD ItsMeBrianD approved these changes

Assignees

@zachstence zachstence

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chromatic action doesn't get changes in PRs from forks
2 participants
@zachstence @ItsMeBrianD