Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: seriesFmt #2800

Closed
archiewood opened this issue Nov 15, 2024 · 2 comments · Fixed by #2816
Closed

[Feature]: seriesFmt #2800

archiewood opened this issue Nov 15, 2024 · 2 comments · Fixed by #2816
Assignees
Labels
customer request An Evidence customer has requested this ui/components Components that are not data viz

Comments

@archiewood
Copy link
Member

archiewood commented Nov 15, 2024

Feature

Ability use the built in fmt functions / excel format codes for series and legend labels

<BarChart
  data=orders
  x=month
  y=num_orders
  series=price
  seriesFmt="usd0"
/>

support all cartesian charts: bar line hist scatter etc

@archiewood archiewood added bug Something isn't working to-review Evidence team to review labels Nov 15, 2024
@archiewood archiewood changed the title [Feature]: legendFmt [Feature]: seriesFmt Nov 15, 2024
@archiewood archiewood added ui/components Components that are not data viz customer request An Evidence customer has requested this and removed bug Something isn't working to-review Evidence team to review labels Nov 15, 2024
@kwongz kwongz self-assigned this Nov 18, 2024
@kwongz
Copy link
Contributor

kwongz commented Nov 18, 2024

@archiewood

With this new prop, is the expected output for this chart that the tooltip hover will show the values formatted to usd0, but the y-axis will remain unchanged?

Image

Does this also need to affect value labels?

Image

I'm having trouble understanding the usage seriesFmt offers that yFmt does not.

@archiewood
Copy link
Member Author

This would be impacting the labels of the series
Image

This is an odd example because it is only relevant if the series name is numeric

@archiewood archiewood linked a pull request Nov 20, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer request An Evidence customer has requested this ui/components Components that are not data viz
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants