Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Preview action for templated pages #30

Open
mcrascal opened this issue May 30, 2023 · 2 comments
Open

Preview action for templated pages #30

mcrascal opened this issue May 30, 2023 · 2 comments
Labels
enhancement New feature or request feature New Feature wontfix This will not be worked on

Comments

@mcrascal
Copy link
Member

Fine tuning -- not for the current release.

Previewing a page that has parameters in the route is counter intuitive -- the extension injects [name_of_parameter] into the url and opens that page.

Given the information that's available to the extension, I think it will be quite difficult to correctly navigate to a parameterized route.

If it's not possible to find these routes, I think it'd be preferable to simply not offer "right click to preview", or the editor action preview button on any markdown that is in a parameterized route.

If it's not possible to distinguish these routes, I would remove right click to preview, and the preview editor action for all evidence pages.

See: https://docs.evidence.dev/core-concepts/templated-pages/

@RandomFractals
Copy link
Contributor

RandomFractals commented May 30, 2023

That is the current v1.0.0 limitation. We did not get the time to dive into templated pages and params rewrite.

Providing preview of those pages might also require better understanding of your data api and how those parameters and dynamic page urls should be created from app routes for Preview.

@RandomFractals RandomFractals added the enhancement New feature or request label May 30, 2023
@RandomFractals RandomFractals added the feature New Feature label Jun 4, 2023
@RandomFractals
Copy link
Contributor

Will not be looked into, or worked on for the v1.1.0 enhancements release, or Sprint 3.

We can revisit this later in June, if you'd like, or think that this advanced feature is worth investing some time into.

@RandomFractals RandomFractals added the wontfix This will not be worked on label Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request feature New Feature wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants