Private key filename

[Alex-Monahan]

This allows you to refer directly to the JSON file that Google outputs instead of having to pass in a key as a string.

One consequence is that the key itself is not persisted within the secret, just the filename. I leave fixing that for another PR!

And, this time, I tested with a debug build so it should actually build and run on other people's machines... In theory!!

Closes #42.

[Alex-Monahan]

Well, the windows errors look like they are coming from DuckDB's httplib that I added to the includes somehow. Odd. I'm not sure where to go next on that, but I can look next week.

[archiewood]

i think this probably means you have the httplib on your machine but not in CI

[archiewood]

might be a modification to CMakeLists but i'm not expert

[archiewood]

Love the functionality in this PR

Some general thoughts:

• I dont like having two HTTP libs - both openSSL and httplib kind of do the same thing

  • The perform_http_request function is currently where we are putting all queries through
  • I think httplib is probably the way to go long term, seems much easier, less ability to screw up
  • in the short term may be easier just to remove httplib and just use the perform_http_request function

• It feels "wrong" to have to get a new token each request. I understand that it's because we are not handling token refresh

  • not averse to this in the short term
    • copypasta in read/copy feels suboptimal though, should abstract
  • long term feels like we should save the token somewhere (perhaps in the secrets manager token type we already have?) and then if the token expires, request a new one

[archiewood]

i think google would normally refer to this as key_file

[archiewood]

Actually, it looks like we might be able to avoid OAuth all together if we are using a service account:

https://developers.google.com/identity/protocols/oauth2/service-account#jwt-auth

This seems like it might be much simpler.

1. read the service account
2. contsruct a JWT
3. pass the JWT as a bearer token