Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options to React entrypoint should match global options configuration #93

Closed
osdiab opened this issue Feb 9, 2021 · 2 comments · Fixed by #119
Closed

options to React entrypoint should match global options configuration #93

osdiab opened this issue Feb 9, 2021 · 2 comments · Fixed by #119
Assignees
@martinbianchi
Labels
integration ease of integration with the donate-button p2

Comments

@osdiab
Copy link
Contributor

osdiab commented Feb 9, 2021 •
edited
Loading

necessary for #48 .

Right now you have to pass a full options configuration to the EveryMonth component (to be renamed), instead of just a partial one. We shouldn't be merging options in the loader script, it should be in the EveryMonth script
@osdiab osdiab changed the title options to ` options to React entrypoint should match global options configuration Feb 9, 2021
@osdiab osdiab added the p2 label Feb 10, 2021
@osdiab osdiab added the integration ease of integration with the donate-button label Feb 10, 2021
@martinbianchi
Copy link
Contributor

@osdiab I want to check with you If I understand correctly. We should move this code inside the <EveryMonth /> component?

@osdiab
Copy link
Contributor Author

osdiab commented Feb 28, 2021

yup!

@martinbianchi martinbianchi mentioned this issue Mar 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinbianchi martinbianchi

Labels
integration ease of integration with the donate-button p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: merge options inside every month component everydotorg/donate-button
2 participants
@osdiab @martinbianchi