Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stiebel ISG as charger (experimental) #7207

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
345 changes: 345 additions & 0 deletions charger/stiebel-isg.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,345 @@
package charger

// LICENSE

// Copyright (c) 2022 premultiply, andig

// This module is NOT covered by the MIT license. All rights reserved.

// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.

// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

import (
"errors"
"fmt"
"math"

"github.com/evcc-io/evcc/api"
"github.com/evcc-io/evcc/charger/stiebel"
"github.com/evcc-io/evcc/core/loadpoint"
"github.com/evcc-io/evcc/util"
"github.com/evcc-io/evcc/util/modbus"
"github.com/evcc-io/evcc/util/sponsor"
"github.com/volkszaehler/mbmd/encoding"
)

// StiebelIsg charger implementation
type StiebelIsg struct {
*embed
log *util.Logger
conn *modbus.Connection
lp loadpoint.API
conf TempConfig
}

type TempConfig struct {
SollAddr, IstAddr uint16
TempDelta float64
ModeAddr uint16
EnableMode uint16
DisableMode uint16
StatusAddr uint16
StatusBits uint16
Speicher float64
Wärmekoeffizient float64
}

func init() {
registry.Add("stiebel-isg", NewStiebelIsgFromConfig)
}

// NewStiebelIsgFromConfig creates a Stiebel ISG charger from generic config
func NewStiebelIsgFromConfig(other map[string]interface{}) (api.Charger, error) {
cc := struct {
modbus.TcpSettings `mapstructure:",squash"`
TempConfig `mapstructure:",squash"`
embed `mapstructure:",squash"`
}{
TcpSettings: modbus.TcpSettings{
ID: 1,
},
TempConfig: TempConfig{
// temp
SollAddr: 522, // WW
IstAddr: 521, // WW
TempDelta: 5, // °C
// enable/disable
ModeAddr: 1500, // Betriebsart
EnableMode: 3, // Komfortbetrieb
DisableMode: 2, // Programmbetrieb
// status
StatusAddr: 2500, // Betriebsstatus
StatusBits: 1 << 5, // WW Betrieb
// medium
Wärmekoeffizient: 4.18, // kJ/kgK
},
embed: embed{
Icon_: "heatpump",
Features_: []api.Feature{api.IntegratedDevice},
},
}

if err := util.DecodeOther(other, &cc); err != nil {
return nil, err
}

return NewStiebelIsg(&cc.embed, cc.URI, cc.ID, cc.TempConfig)
}

// NewStiebelIsg creates Stiebel ISG charger
func NewStiebelIsg(embed *embed, uri string, slaveID uint8, conf TempConfig) (api.Charger, error) {
conn, err := modbus.NewConnection(uri, "", "", 0, modbus.Tcp, slaveID)
if err != nil {
return nil, err
}

if !sponsor.IsAuthorized() {
return nil, api.ErrSponsorRequired
}

log := util.NewLogger("stiebel")
conn.Logger(log.TRACE)

wb := &StiebelIsg{
embed: embed,
log: log,
conn: conn,
conf: conf,
}

return wb, nil
}

func (wb *StiebelIsg) sollIst() (float64, float64, error) {
soll, err := wb.conn.ReadInputRegisters(wb.conf.SollAddr, 1)
if err != nil {
return 0, 0, err
}

ist, err := wb.conn.ReadInputRegisters(wb.conf.IstAddr, 1)
if err != nil {
return 0, 0, err
}

if stiebel.Invalid(soll) || stiebel.Invalid(ist) {
return 0, 0, errors.New("invalid reading")
}

return float64(encoding.Int16(soll)) / 10, float64(encoding.Int16(ist)) / 10, nil
}

// Status implements the api.Charger interface
func (wb *StiebelIsg) Status() (api.ChargeStatus, error) {
res := api.StatusNone

soll, ist, err := wb.sollIst()
if err != nil {
return res, err
}

energyRequired := (soll - ist) * wb.conf.Speicher * wb.conf.Wärmekoeffizient / 3.6e3
wb.log.DEBUG.Printf("ist: %.1f°C, soll: %.1f°C, energy required: %.3fkWh", ist, soll, energyRequired)

charging, err := wb.charging()
if err != nil {
return res, err
}

// TODO StatusA
res = api.StatusB

// become "connected" if temp is outside of temp delta
if soll-ist > wb.conf.TempDelta {
res = api.StatusB
}

if charging {
res = api.StatusC
}

return res, nil
}

func (wb *StiebelIsg) charging() (bool, error) {
b, err := wb.conn.ReadInputRegisters(wb.conf.StatusAddr, 1)
if err != nil {
return false, err
}

return encoding.Uint16(b)&wb.conf.StatusBits != 0, nil
}

func (wb *StiebelIsg) mode() (uint16, error) {
b, err := wb.conn.ReadHoldingRegisters(wb.conf.ModeAddr, 1)
if err != nil {
return 0, err
}

return encoding.Uint16(b), nil
}

// Enabled implements the api.Charger interface
func (wb *StiebelIsg) Enabled() (bool, error) {
mode, err := wb.mode()
return mode == wb.conf.EnableMode, err
}

// Enable implements the api.Charger interface
func (wb *StiebelIsg) Enable(enable bool) error {
enabled, err := wb.Enabled()
if err != nil {
return err
}

if enabled == enable {
return nil
}

// don't disable unless pump is silent
if enabled && !enable {
charging, err := wb.charging()
if err != nil {
return err
}

if charging {
return api.ErrMustRetry
}
}

// set new mode
value := map[bool]uint16{true: wb.conf.EnableMode, false: wb.conf.DisableMode}[enable]

mode, err := wb.mode()
if mode != value && err == nil {
// TODO remove
return errors.New("forbidden")

// _, err = wb.conn.WriteSingleRegister(wb.conf.ModeAddr, value)
}

return err
}

// MaxCurrent implements the api.Charger interface
func (wb *StiebelIsg) MaxCurrent(current int64) error {
return nil
}

var _ api.Battery = (*StiebelIsg)(nil)

func (wb *StiebelIsg) Soc() (float64, error) {
_, ist, err := wb.sollIst()
return ist, err
}

var _ api.SocLimiter = (*StiebelIsg)(nil)

Check failure on line 244 in charger/stiebel-isg.go

View workflow job for this annotation

GitHub Actions / Integration

cannot use (*StiebelIsg)(nil) (value of type *StiebelIsg) as "github.com/evcc-io/evcc/api".SocLimiter value in variable declaration: *StiebelIsg does not implement "github.com/evcc-io/evcc/api".SocLimiter (missing method GetLimitSoc)

Check failure on line 244 in charger/stiebel-isg.go

View workflow job for this annotation

GitHub Actions / Build

cannot use (*StiebelIsg)(nil) (value of type *StiebelIsg) as "github.com/evcc-io/evcc/api".SocLimiter value in variable declaration: *StiebelIsg does not implement "github.com/evcc-io/evcc/api".SocLimiter (missing method GetLimitSoc)

Check failure on line 244 in charger/stiebel-isg.go

View workflow job for this annotation

GitHub Actions / Lint

cannot use (*StiebelIsg)(nil) (value of type *StiebelIsg) as "github.com/evcc-io/evcc/api".SocLimiter value in variable declaration: *StiebelIsg does not implement "github.com/evcc-io/evcc/api".SocLimiter (missing method GetLimitSoc)) (typecheck)

Check failure on line 244 in charger/stiebel-isg.go

View workflow job for this annotation

GitHub Actions / Lint

cannot use (*StiebelIsg)(nil) (value of type *StiebelIsg) as "github.com/evcc-io/evcc/api".SocLimiter value in variable declaration: *StiebelIsg does not implement "github.com/evcc-io/evcc/api".SocLimiter (missing method GetLimitSoc) (typecheck)

Check failure on line 244 in charger/stiebel-isg.go

View workflow job for this annotation

GitHub Actions / Lint

cannot use (*StiebelIsg)(nil) (value of type *StiebelIsg) as "github.com/evcc-io/evcc/api".SocLimiter value in variable declaration: *StiebelIsg does not implement "github.com/evcc-io/evcc/api".SocLimiter (missing method GetLimitSoc)) (typecheck)

Check failure on line 244 in charger/stiebel-isg.go

View workflow job for this annotation

GitHub Actions / Lint

cannot use (*StiebelIsg)(nil) (value of type *StiebelIsg) as "github.com/evcc-io/evcc/api".SocLimiter value in variable declaration: *StiebelIsg does not implement "github.com/evcc-io/evcc/api".SocLimiter (missing method GetLimitSoc)) (typecheck)

Check failure on line 244 in charger/stiebel-isg.go

View workflow job for this annotation

GitHub Actions / Test

cannot use (*StiebelIsg)(nil) (value of type *StiebelIsg) as "github.com/evcc-io/evcc/api".SocLimiter value in variable declaration: *StiebelIsg does not implement "github.com/evcc-io/evcc/api".SocLimiter (missing method GetLimitSoc)

func (wb *StiebelIsg) TargetSoc() (float64, error) {
// TODO soll
// soll, _, err := wb.sollIst()
// return soll, err
return 100, nil
}

var _ api.Diagnosis = (*StiebelIsg)(nil)

// Diagnose implements the api.Diagnosis interface
func (wb *StiebelIsg) Diagnose() {
// if _, err := wb.conn.WriteSingleRegister(1510, 28*10); err != nil {
// fmt.Println(err)
// }

// {
// fmt.Println()
// reg := stiebel.Block3[0]
// if b, err := wb.conn.ReadInputRegisters(reg.Addr(), 1); err == nil {
// wb.print(reg, b)
// }
// }

// {
// fmt.Println()
// ist, _ := wb.conn.ReadInputRegisters(521, 1)
// soll, _ := wb.conn.ReadInputRegisters(522, 1)

// fmt.Println((float64(encoding.Int16(soll))-float64(encoding.Int16(ist)))/10*100*4.2/3.6e3, "kWh")
// }

for _, reg := range stiebel.Block1 {
if b, err := wb.conn.ReadInputRegisters(reg.Addr(), 1); err == nil {
wb.print(reg, b)
}
}

fmt.Println()
for _, reg := range stiebel.Block2 {
if b, err := wb.conn.ReadHoldingRegisters(reg.Addr(), 1); err == nil {
wb.print(reg, b)
}
}

// fmt.Println()
// for _, reg := range stiebel.Block3 {
// if b, err := wb.conn.ReadInputRegisters(reg.Addr(), 1); err == nil {
// wb.print(reg, b)
// }
// }

fmt.Println()
for _, reg := range stiebel.Block4 {
if b, err := wb.conn.ReadInputRegisters(reg.Addr(), 1); err == nil {
wb.print(reg, b)
}
}

fmt.Println()
for _, reg := range stiebel.Block5 {
if b, err := wb.conn.ReadHoldingRegisters(reg.Addr(), 1); err == nil {
wb.print(reg, b)
}
}

fmt.Println()
for _, reg := range stiebel.Block6 {
if b, err := wb.conn.ReadInputRegisters(reg.Addr(), 1); err == nil {
wb.print(reg, b)
}
}
}

func (wb *StiebelIsg) print(reg stiebel.Register, b []byte) {
name := reg.Name
if reg.Comment != "" {
name = fmt.Sprintf("%s (%s)", name, reg.Comment)
}

switch reg.Typ {
case stiebel.Bits:
if stiebel.Invalid(b) {
return
}
fmt.Printf("\t%d %s:\t%04X\n", reg.Addr(), name, b)

default:
f := reg.Float(b)
if math.IsNaN(f) {
return
}

fmt.Printf("\t%d %s:\t%.1f%s\n", reg.Addr(), name, f, reg.Unit)
}
}

// LoadpointControl implements loadpoint.Controller
func (c *StiebelIsg) LoadpointControl(lp loadpoint.API) {
c.lp = lp
}
Loading
Loading