Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AU Region for Saic/MG #17544

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Conversation

mjhgmailcom
Copy link
Contributor

@mjhgmailcom mjhgmailcom commented Dec 2, 2024

Fix #17497

SAIC (MG) Vehicle Template - Added "region" parameter.
Defaults to EU if not provided (https://gateway-mg-eu.soimt.com/api.app/v1/), otherwise can set AU (https://gateway-mg-au.soimt.com/api.app/v1/).

@mjhgmailcom mjhgmailcom changed the title #17497 Added AU Region for Saic/MG Added AU Region for Saic/MG Dec 2, 2024
@andig andig added the vehicles Specific vehicle support label Dec 2, 2024
@andig
Copy link
Member

andig commented Dec 2, 2024

Did a simplification. It would be really nice to refactor the CreateRequest method. It should take a path and a baseurl und not have the baseurl repeated.

@andig andig marked this pull request as draft December 2, 2024 20:15
@mjhgmailcom
Copy link
Contributor Author

Refactored As Requested.

@mjhgmailcom mjhgmailcom marked this pull request as ready for review December 3, 2024 09:26
vehicle/saic/api.go Outdated Show resolved Hide resolved
@mjhgmailcom
Copy link
Contributor Author

Ok, done.

@andig andig merged commit 28b0919 into evcc-io:master Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vehicles Specific vehicle support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MG Vehicle Config: Please Add Region and/or API URL option
2 participants