is it right process() method is deprecated?

[SeonJK]

Hi! I forked this repository and cloned into my local. And I have a question.

In EuTxManager.java, process() method is deprecated and replaced by setCode() method.
However, in README.md, GETTING_STARTED.md and GETTING_STARTED_KR.md, they still describe process() method for generating sound with count.

My question is...

• surely process() is deprecated, do we have to update documents from process() to setCode()?
• If we have to update documents, I think it is necessary to have another method for generating sound with count. How about update process() to play() method?

[designe]

Hi @SeonJK

You're right! you found comment & documentation error

euphony/euphony/src/main/java/co/euphony/tx/EuTxManager.java

Line 143 in f463bfc

* @deprecated Replaced by {@link #setCode()}, deprecated for naming issue

Actually, The setCode() is not a replacement for the process(). We need to modify here (setCode() -> play())

euphony/euphony/src/main/java/co/euphony/tx/EuTxManager.java

Line 146 in f463bfc

public void process() { play(1, PlayerEngine.ANDROID_DEFAULT_ENGINE); }

As you mentioned, play() is the proper function for generating sound. so, we need to update comment & documentation.
Thanks for finding them! Could you make a PR for this?

[SeonJK]

Thanks for reply!!
I will make a PR for this.

[SeonJK]

I just made a PR!!

[SeonJK]

I have one more question here.
in GETTING_STARTED.md, process(-1) generates sound infinitely.
does play(-1) work same as process(-1)?

[designe]

euphony/euphony/src/main/java/co/euphony/tx/EuTxManager.java

Line 152 in f463bfc

public void process(int count) { play(count, PlayerEngine.ANDROID_DEFAULT_ENGINE); }

Actually, process() function is wrapping of play function. exactly same :)