Skip to content

Commit f7528db

Browse files
committed
internal function convention for delegateToManagementImpl
Spearbit #3
1 parent 8466db6 commit f7528db

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/EulerSwap.sol

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,9 @@ contract EulerSwap is IEulerSwap, UniswapHook {
2424
managementImpl = managementImpl_;
2525
}
2626

27-
function delegateToManagementImpl() internal {
28-
(bool success, bytes memory result) = managementImpl.delegatecall(msg.data);
29-
if (!success) {
30-
assembly {
31-
revert(add(32, result), mload(result))
32-
}
33-
}
34-
}
35-
3627
/// @inheritdoc IEulerSwap
3728
function activate(DynamicParams calldata, InitialState calldata) external {
38-
delegateToManagementImpl();
29+
_delegateToManagementImpl();
3930

4031
// Uniswap hook activation
4132

@@ -44,12 +35,12 @@ contract EulerSwap is IEulerSwap, UniswapHook {
4435

4536
/// @inheritdoc IEulerSwap
4637
function setManager(address, bool) external {
47-
delegateToManagementImpl();
38+
_delegateToManagementImpl();
4839
}
4940

5041
/// @inheritdoc IEulerSwap
5142
function reconfigure(DynamicParams calldata, InitialState calldata) external {
52-
delegateToManagementImpl();
43+
_delegateToManagementImpl();
5344
}
5445

5546
/// @inheritdoc IEulerSwap
@@ -160,4 +151,13 @@ contract EulerSwap is IEulerSwap, UniswapHook {
160151

161152
SwapLib.finish(ctx);
162153
}
154+
155+
function _delegateToManagementImpl() internal {
156+
(bool success, bytes memory result) = managementImpl.delegatecall(msg.data);
157+
if (!success) {
158+
assembly {
159+
revert(add(32, result), mload(result))
160+
}
161+
}
162+
}
163163
}

0 commit comments

Comments
 (0)