Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equivalence with lintr #6

Open
48 of 85 tasks
etiennebacher opened this issue Jul 1, 2024 · 2 comments
Open
48 of 85 tasks

Equivalence with lintr #6

etiennebacher opened this issue Jul 1, 2024 · 2 comments

Comments

@etiennebacher
Copy link
Owner

etiennebacher commented Jul 1, 2024 •
edited
Loading

https://lintr.r-lib.org/dev/reference/#individual-linters

  • absolute_path_linter - Hard, see Absolute paths detection is broken #42
  • any_duplicated_linter
  • any_is_na_linter
  • assignment_linter
  • backport_linter
  • boolean_arithmetic_linter
  • brace_linter
  • class_equals_linter
  • commas_linter
  • commented_code_linter - Not possible since this only appears as kind "comment" in tree-sitter. Potentially: Highlight ROxygen tags r-lib/tree-sitter-r#68
  • condition_message_linter
  • conjunct_test_linter
  • consecutive_assertion_linter
  • cyclocomp_linter
  • duplicate_argument_linter
  • empty_assignment_linter
  • equals_na_linter
  • expect_comparison_linter
  • expect_identical_linter
  • expect_length_linter
  • expect_named_linter
  • expect_not_linter
  • expect_null_linter
  • expect_s3_class_linter
  • expect_s4_class_linter
  • expect_true_false_linter
  • expect_type_linter
  • extraction_operator_linter - deprecated
  • fixed_regex_linter
  • for_loop_index_linter
  • function_argument_linter
  • function_left_parentheses_linter
  • function_return_linter
  • if_not_else_linter
  • ifelse_censor_linter Won't implement, I think it makes the code less readable
  • implicit_assignment_linter
  • implicit_integer_linter Won't implement, I think this is rarely useful and makes the code less readable
  • indentation_linter
  • infix_spaces_linter
  • inner_combine_linter
  • is_numeric_linter
  • keyword_quote_linter
  • length_levels_linter
  • length_test_linter
  • lengths_linter
  • library_call_linter
  • line_length_linter
  • list_comparison_linter
  • literal_coercion_linter
  • matrix_apply_linter
  • missing_argument_linter
  • missing_package_linter
  • namespace_linter
  • nested_ifelse_linter
  • nonportable_path_linter
  • numeric_leading_zero_linter
  • object_length_linter
  • object_name_linter
  • object_usage_linter
  • outer_negation_linter
  • package_hooks_linter
  • paren_body_linter
  • paste_linter
  • pipe_call_linter
  • pipe_consistency_linter
  • pipe_continuation_linter
  • quotes_linter
  • redundant_equals_linter
  • redundant_ifelse_linter
  • regex_subset_linter
  • rep_len_linter
  • repeat_linter
  • routine_registration_linter
  • sample_int_linter
  • scalar_in_linter
  • semicolon_linter
  • seq_linter
  • sort_linter
  • spaces_inside_linter
  • spaces_left_parentheses_linter
  • sprintf_linter
  • stopifnot_all_linter
  • string_boundary_linter
  • strings_as_factors_linter
  • system_file_linter
  • T_and_F_symbol_linter
  • todo_comment_linter
  • trailing_blank_lines_linter
  • trailing_whitespace_linter
  • undesirable_function_linter
  • undesirable_operator_linter
  • unnecessary_concatenation_linter
  • unnecessary_lambda_linter
  • unnecessary_nesting_linter
  • unnecessary_placeholder_linter
  • unreachable_code_linter
  • unused_import_linter
  • vector_logic_linter
  • which_grepl_linter
  • whitespace_linter
  • yoda_test_linter
@etiennebacher

This comment was marked as outdated.

Sign in to view
@etiennebacher
Copy link
Owner Author

etiennebacher commented Sep 16, 2024 •
edited
Loading

I think a linter shouldn't take care of whitespaces and other things that don't modify the AST but are "purely aesthetic", that's the role of a formatter (and I don't think ast-grep is the right tool for this). So I remove from the list all linters related to formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@etiennebacher