Skip to content

Gif admin role transfer #723

@rapidddenis

Description

@rapidddenis

In current implementation some RegistryAdmin functions are restricted to GIF_ADMIN_ROLE. This role is granted upon registry admin initialization, in completeSetup().
Problem:
RegistryAdmin does not provide any function for granting/revoking roles thus GIF_ADMIN_ROLE cannot be transferred

Solution 1:
1). add transferGifAdmin(address from, address to)
2). transfer is atomic combination of revoke(oldAddress) and grant(newAddress)

Solution 2:
1). make RegistryAdmin inherit NftOwnable
2). link it to nft id owned by gif admin (e.g. some service nft id or staking)
3). for function restricted to gif admin role use onlyOwner() modifier instead of restricted()

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions