-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Test ethdebug program output against corresponding schema #16009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b59db8c to
976bb36
Compare
dc9001a to
dbdbc38
Compare
dbdbc38 to
b857048
Compare
3c02df0 to
f9a0985
Compare
345d936 to
dbb9928
Compare
| return dictionary | ||
|
|
||
|
|
||
| @pytest.fixture(params=["input_file.json", "input_file_eof.json"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have this already implemented in a way that it will dynamically pick files and test it.. e.g. the test will search for all json files defined in a specific directory and will then verify whether ethdebug output is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already possible by adding more stuff to the params kwarg. depending on what you want to test, you can rglob json files from some directory ahead of test time and add them there to the list
ae80060 to
082d7f9
Compare
|
I think it would be awesome to integrate this within our command-line tests. I could imagine that it would be really nice to allow the following: if in a command-line test directory the special file |
dbb9928 to
03e6b2f
Compare
082d7f9 to
367e14b
Compare
7eecf23 to
e696889
Compare
d56ec45 to
535326b
Compare
e696889 to
667d2e3
Compare
535326b to
e0f9da3
Compare
2f4f25b to
0ca8800
Compare
e0f9da3 to
f7836f4
Compare
|
This pull request is stale because it has been open for 14 days with no activity. |
0ca8800 to
dd25b24
Compare
55c40da to
1dc6a24
Compare
1dc6a24 to
2468801
Compare
matheusaaguiar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already approved before, so I just gave it a quick pass and approved again.
2468801 to
41eb541
Compare
["evm.bytecode.ethdebug", "evm.deployedBytecode.ethdebug"]and["input_file.json", "input_file_eof.json"]Due to the EOF test and invalid instructions with negative offsets, this PR depends on #15994 which fixes/implements these things.
The output without these fixes looks like this: https://app.circleci.com/pipelines/github/ethereum/solidity/39379/workflows/982d78f3-9c42-4849-b48f-cd01a82cd4a4/jobs/1822516