- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.2k
Fix Typographical Errors in Solidity Test Files #15873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            16 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      e1b0e46
              
                Updating copyright year to 2025
              
              
                xiaobei0715 4cd95b3
              
                fix typo
              
              
                 7ab7f07
              
                fix typo
              
              
                 0856073
              
                fix typo
              
              
                 e59fb10
              
                fix typo
              
              
                 777eb5e
              
                Update TestFileParserTests.cpp
              
              
                vtjl10 94cd00b
              
                typo fix
              
              
                 ad62bef
              
                typo fix
              
              
                 05946e1
              
                SMTChecker: Allow printing queries for all solvers
              
              
                blishko b92b756
              
                Add SWAPN/DUPN.
              
              
                ekpyron a434cbf
              
                ConstantEvaluator: Add `tryEvaluate` method that swallows errors
              
              
                blishko 1288c76
              
                SMTChecker: Ignore errors that might occur during constant evaluation
              
              
                 141c175
              
                Merge branch 'develop' into simple-1
              
              
                vtjl10 4d85091
              
                Merge branch 'develop' into simple-1
              
              
                vtjl10 c09c0aa
              
                Merge branch 'develop' into simple-1
              
              
                vtjl10 1b0322f
              
                Merge branch 'develop' into simple-1
              
              
                vtjl10 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
            File renamed without changes.
          
    
        
          
          
            12 changes: 12 additions & 0 deletions
          
          12 
        
  test/libsolidity/semanticTests/multiSource/free_different_integer_types.sol
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| ==== Source: s1.sol ==== | ||
| function f(uint24) pure returns (uint) { return 24; } | ||
| function g(bool) pure returns (bool) { return true; } | ||
| ==== Source: s2.sol ==== | ||
| import {f as g, g as g} from "s1.sol"; | ||
| contract C { | ||
| function foo() public pure returns (uint, bool) { | ||
| return (g(2), g(false)); | ||
| } | ||
| } | ||
| // ---- | ||
| // foo() -> 24, true | 
            File renamed without changes.
          
    
        
          
          
            11 changes: 11 additions & 0 deletions
          
          11 
        
  test/libsolidity/syntaxTests/multiSource/free_different_integer_types.sol
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ==== Source: s1.sol ==== | ||
| function f(uint) pure returns (uint) { return 24; } | ||
| function g() pure returns (bool) { return true; } | ||
| ==== Source: s2.sol ==== | ||
| import {f as g, g as g} from "s1.sol"; | ||
| contract C { | ||
| function foo() public pure returns (uint, bool) { | ||
| return (g(2), g()); | ||
| } | ||
| } | ||
| // ---- | 
            File renamed without changes.
          
    
        
          
          
            19 changes: 19 additions & 0 deletions
          
          19 
        
  test/libsolidity/syntaxTests/specialFunctions/abidecode/abi_decode_member_access.sol
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| library L { | ||
| struct S { int a; } | ||
| enum State { idle, running, blocked } | ||
| } | ||
|  | ||
| contract D { | ||
| struct X { uint b; } | ||
| enum Color { red, green, blue } | ||
| } | ||
|  | ||
| contract C { | ||
| function f() pure public { | ||
| abi.decode("", (L.S)); | ||
| abi.decode("", (L.State)); | ||
| abi.decode("", (D.X)); | ||
| abi.decode("", (D.Color)); | ||
| } | ||
| } | ||
| // ---- | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR seems to add 3 new tests now. Was it meant to be a rename? If so, you probably forgot to commit the removal of the file with the old name.