Update EIP-7896: Fix JSON syntax in EIP-7896 ABI example #10806
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
Collaborator
File
|
eth-bot
changed the title
frangio
reviewed
Nov 18, 2025
| "version": "abi-v1", | ||
| "spec": [ | ||
| { | ||
| "type": "function" |
Contributor
Author
There was a problem hiding this comment.
The type field defaults to "function" per the ABI spec, so it's redundant when the item is a function. I removed it to simplify the example, but happy to restore it if you think explicit is better here.
Contributor
There was a problem hiding this comment.
Please add it back for clarity.
Contributor
Author
There was a problem hiding this comment.
Restored "type": "function" in the example.
Contributor
|
will let the author take a call on this first |
g11tech
approved these changes
Dec 4, 2025
Contributor
g11tech
left a comment
g11tech
left a comment
There was a problem hiding this comment.
lgtm for just dropping the trailing , to make it a valid json
Contributor
|
Superceded by #10871 as there was another error in JSON that wasn't fixed in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop the trailing comma after the
"outputs": []array so the snippet becomes valid JSON