Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccountAccessParser Improvement #666

Open
ElliotFriedman opened this issue Feb 24, 2025 · 1 comment
Open

AccountAccessParser Improvement #666

ElliotFriedman opened this issue Feb 24, 2025 · 1 comment

Comments

@ElliotFriedman
Copy link
Contributor

The AccountAccessParser library has lots of duplicate code looping over an array of VmSafe.AccountAccess and then subsequently looping over the array of storageAccesses contained inside each AccountAccess entry.

It would be nice to have a function that returns an array of all storage writes for a given AccountAccess array.

This function would allow us to remove duplicate code in functions getUniqueWrites and getStateDiffFor.
@ElliotFriedman ElliotFriedman mentioned this issue Feb 24, 2025
Merged
@ElliotFriedman
Copy link
Contributor Author

This issue should not block mainnet as this is a small refactor/cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ElliotFriedman