test_mismatched_extensions test fails on case-insensitive filesystems

[amarshall]

I tried have a look through the logic, but the overall intent is a bit over my head as I’m not familiar with the code and only use this package indirectly. Fails on e.g. macOS. Test log:

======================================================================
FAIL: test_mismatched_extensions (__main__.TestDbfFunctions.test_mismatched_extensions)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/nix-build-python3.11-dbf-0.99.9.drv-0/dbf-0.99.9/dbf/test.py", line 4822, in test_mismatched_extensions
    self.assertEqual(table._meta.memoname, new_memo_name)
AssertionError: '/private/tmp/nix-build-python3.11-dbf-0.99.9.drv-0/tmpedpvv9u9/temptable.dbt' != '/private/tmp/nix-build-python3.11-dbf-0.99.9.drv-0/tmpedpvv9u9/temptable.Dbt'
- /private/tmp/nix-build-python3.11-dbf-0.99.9.drv-0/tmpedpvv9u9/temptable.dbt
?                                                                          ^
+ /private/tmp/nix-build-python3.11-dbf-0.99.9.drv-0/tmpedpvv9u9/temptable.Dbt
?                                                                          ^

[thornycrackers]

I think the problem here is around this line. There's some logic to look for files with different case sensitivities but this line will always be True for the test case on darwin. You can test this out by stopping right after the call to os.rename and checking the values.

I don't know what the right answer is, but wanted to add some more information to help come up with a solution.

[amarshall]

From what I remember back when I dug into this a bit, I wasn’t really sure if the implementation was actually correct, or if it was really even needed. But I don’t really have the context for why it’s trying to do all this filename case handling.

[ethanfurman]

Thank you for the further info.