Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: allow missing environment description #18

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

albestro
Copy link
Contributor

@albestro albestro commented Mar 7, 2024

The environment schema allows not specifying description (actually it is the default).

Without this PR, such condition would lead to an exception (i.e. calling None.strip()).

Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bcumming bcumming merged commit e50121f into eth-cscs:master Mar 8, 2024
3 checks passed
@albestro albestro deleted the alby/allow-empty-descriptions branch March 8, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants