Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MPI in the container #13

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

rjanalik
Copy link
Collaborator

@rjanalik rjanalik commented Oct 2, 2024

No description provided.

@rjanalik rjanalik requested a review from finkandreas October 2, 2024 13:10
@rjanalik rjanalik marked this pull request as ready for review October 3, 2024 11:55
Copy link
Collaborator

@finkandreas finkandreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an idea, you could instead of providing your own MPI test use the spack package osu-microbenchmarks, and run e.g. osu-bw.
Then the test could even do a verification if bandwidth speed is above an expected value (e.g. that would also test if we actually really run with native MPI performance).

That's just an idea, that you might want to consider. If you want to keep this test, then the inline comments are relevant.

ci/templates/test_image.yml.j2 Outdated Show resolved Hide resolved
ci/templates/test_image.yml.j2 Show resolved Hide resolved
test/mpi_simple/Dockerfile.mpi_simple Show resolved Hide resolved
@rjanalik rjanalik force-pushed the test/mpi branch 5 times, most recently from e9b94aa to ebfdbb2 Compare October 15, 2024 19:13
@rjanalik rjanalik force-pushed the test/mpi branch 3 times, most recently from d86670b to 1f81d1f Compare October 18, 2024 21:13
@rjanalik rjanalik requested a review from finkandreas October 18, 2024 21:14
ci/templates/test_image.yml.j2 Outdated Show resolved Hide resolved
ci/templates/test_image.yml.j2 Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants