Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #8

Open
wants to merge 82 commits into
base: main
Choose a base branch
from
Open

Add documentation #8

wants to merge 82 commits into from

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented May 22, 2024

  • Close Add documentation #7
  • Add GitHub Action to automatically deploy documentation on the gh-pages branch

Documentation Preview

The documentation is currently incomplete: only one function per algorithm is documented, plus the helper functions. It will be completed once the phrasing is agreed upon.

@RMeli RMeli added the documentation Improvements or additions to documentation label May 22, 2024
@RMeli RMeli self-assigned this May 22, 2024
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
DLA-Future-Fortran.md Outdated Show resolved Hide resolved
@rasolca
Copy link
Collaborator

rasolca commented May 24, 2024

Preliminary questions:
Is the doc already available somewhere?
Any plan to keep the documentation of released versions?

@RMeli
Copy link
Member Author

RMeli commented May 24, 2024

Is the doc already available somewhere?

There is a preview from my fork: https://rmeli.github.io/DLA-Future-Fortran

Any plan to keep the documentation of released versions?

Not really... I'm open to suggestions.

DLA-Future-Fortran.md Outdated Show resolved Hide resolved
@RMeli RMeli marked this pull request as ready for review May 24, 2024 10:34
@RMeli RMeli marked this pull request as draft May 24, 2024 10:58
DLA-Future-Fortran.md Outdated Show resolved Hide resolved
src/dlaf_fortran.f90 Outdated Show resolved Hide resolved
@RMeli RMeli requested a review from rasolca December 3, 2024 16:35
@RMeli RMeli marked this pull request as ready for review December 3, 2024 16:35
@RMeli RMeli mentioned this pull request Dec 5, 2024
@RMeli
Copy link
Member Author

RMeli commented Dec 6, 2024

I merged #26 and added documentation for the new functions. I think it should be good to go for a final review.

Documentation Preview

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do a thorough review next week, but this one stood out too much, that I didn't want to forget to comment about it.

DLA-Future-Fortran.md Outdated Show resolved Hide resolved
Co-authored-by: Mikael Simberg <[email protected]>
@RMeli RMeli requested a review from msimberg December 6, 2024 10:45
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
Comment on lines +142 to +157
!! Cholesky decomposition for a distributed single-precision real symmetric positive definite matrix \(\mathbf{A}\)
!! {!docs/snippets/note-host-matrix.md!}
character, intent(in) :: uplo
!! {!docs/snippets/uplo.md!}
integer, intent(in) :: n
!! {!docs/snippets/n.md!}
real(kind=sp), dimension(:, :), target, intent(inout) :: a
integer, intent(in) :: ia, ja
!! {!docs/snippets/a.md!}
integer, intent(in) :: ia
!! {!docs/snippets/ia.md!}
integer, intent(in) :: ja
!! {!docs/snippets/ja.md!}
integer, dimension(9), intent(in) :: desca
!! {!docs/snippets/desca.md!}
integer, target, intent(out) :: info
!! {!docs/snippets/info.md!}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I didn't expect to see this here, but it's really nice (I'm referring to the inclusion of snippets)! My only concern is that this means there are no (readable) docs just while browsing the code, but I think it's still a net benefit to ensure the published documentation is consistent. Most users will not be browsing the code.

Copy link
Member Author

@RMeli RMeli Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too thought that it is a net benefit. (You have to look only at a few files to spot all my typos... =P)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation
4 participants