add releases to JSR #291
Merged
add releases to JSR #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedx
reviewed
Jun 14, 2024
| @@ -34,8 +34,8 @@ export class Eta { | |||
| renderStringAsync = renderStringAsync; | |||
|
|
|||
| filepathCache: Record<string, string> = {}; | |||
| templatesSync = new Cacher<TemplateFunction>({}); | |||
| templatesAsync = new Cacher<TemplateFunction>({}); | |||
| templatesSync: Cacher<TemplateFunction> = new Cacher<TemplateFunction>({}); | |||
There was a problem hiding this comment.
These annotations are useless thanks to TypeScript type inference.
There was a problem hiding this comment.
Yep, JSR complains though; it won't generate docs for types that take too many cycles to resolve; running the dry-run it said to add explicit types for those interfaces to enable auto-docs.
There was a problem hiding this comment.
Any speedup is probably imperceptible on these in any non-constrained system, but I figured it wouldn't hurt to add them.
|
@josh-hemphill thanks so much for implementing this! I just merged and published, so https://jsr.io/@eta-dev/[email protected] is live! |
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a step in the release pipeline to update a
jsr.jsonwhen creating a new release version, and then release to JSR if npm release succeeded.Just tried shortening the update scripts, I could just put it inline in the scripts if you prefer:
{ "postversion": "node -e \"let r=require;r('fs').writeFileSync('jsr.json', JSON.stringify({...r('./jsr.json'),version: r('./package.json').version},null, 2)+'\\n');\"", }The only other step to be able to release to JSR would be registering the package scope/name and auth on the first upload.
closes #290