Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve build failing due to connectors null logo #708

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Brenosalv
Copy link
Collaborator

#707

Changes

  • Prevent Gatsby from accessing gatsbyImageData of null logo property.
  • Add placeholder icon when logo is null on integration and connector pages and the connector filter icons.

Tests / Screenshots

  • scenarios you tested with screenshots

@Brenosalv Brenosalv added bug Something isn't working generate-pr-preview Used to kick off a preview build for a PR labels Feb 25, 2025
@Brenosalv Brenosalv self-assigned this Feb 25, 2025
@Brenosalv Brenosalv linked an issue Feb 25, 2025 that may be closed by this pull request
@Brenosalv
Copy link
Collaborator Author

Not sure about the icon:
image

@Brenosalv
Copy link
Collaborator Author

@travjenkins Recently the Monday logo was added with this size and format:
image
image

Is it possible to replace it with the same size of the other connector logos? Just removing the "monday" and keeping the image of the logo would work.

Copy link

Visit the preview URL for this PR (updated for commit 793c009):

https://estuary-marketing--pr708-brenosalv-bug-707-bu-58rpxwb1.web.app

(expires Wed, 12 Mar 2025 01:40:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed. We are already filtering this out up above

image

Comment on lines +40 to +45
const sourceConnectorLogo = sourceConnector.logo
? getImage(sourceConnector.logo?.childImageSharp?.gatsbyImageData)
: null;
const destinationConnectorLogo = destConnector.logo
? getImage(destConnector.logo?.childImageSharp?.gatsbyImageData)
: null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If destConnector.logo?.childImageSharp?.gatsbyImageData is optionally chained then the ternary should probably just check the full chain to get safe.

Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needs to happen.

@travjenkins
Copy link
Member

@Brenosalv - no we cannot change the Monday logo. Their rules say it needs the full wide logo. The dashboard had a bug so we pushed a quick change to make the logo smaller while we fix it.

Soon it'll be bigger but still wide.

@travjenkins
Copy link
Member

@Brenosalv

For the default icon we should use a cloud or something. For Captures (Sources) we use a cloud with arrow pointing up and for materializations (destinations) cloud with arrow pointing down.

image

@travjenkins
Copy link
Member

To be clear - this does not solve the problem. The problem is not really due to connector logos being null. The issue is that connector logos that are 100% not null and are in the db are becoming null somehow.

This means by always handling null you can have two builds with the same input that end up with different output. This is a big deal as it can cause weird outcomes.

We still have to 100% figure out why logos that are there are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working generate-pr-preview Used to kick off a preview build for a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing due to connector's null logo
2 participants