Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add id to CTA links and buttons #688

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add id to CTA links and buttons #688

wants to merge 16 commits into from

Conversation

Brenosalv
Copy link
Collaborator

@Brenosalv Brenosalv commented Feb 13, 2025 •
edited
Loading

#651

Changes

  • Add id attributes and props to all CTA link and button elements and components.

Tests / Screenshots

Two examples:

image image

@Brenosalv Brenosalv added the generate-pr-preview Used to kick off a preview build for a PR label Feb 13, 2025
@Brenosalv Brenosalv self-assigned this Feb 13, 2025
@Brenosalv Brenosalv linked an issue Feb 13, 2025 that may be closed by this pull request
Add IDs to all CTAs on the page #651
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit c781888):

https://estuary-marketing--pr688-brenosalv-feature-65-llsypbk4.web.app

(expires Wed, 12 Mar 2025 18:55:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@Brenosalv
Copy link
Collaborator Author

@danthelion I added id to all the CTA buttons, trying to cover all the buttons and links that might be important to track. I think we could add id to menu links as well. What do you think?

@Brenosalv Brenosalv marked this pull request as ready for review February 14, 2025 17:38
@Brenosalv
Copy link
Collaborator Author

@danthelion Is it possible to test the buttons/links before merging?

travjenkins
travjenkins previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

travjenkins
travjenkins reviewed Feb 25, 2025
View reviewed changes
src/components/Bio/index.tsx Outdated
@@ -35,6 +35,7 @@ const Bio = ({ authors }: BioProps) => {

const combined = (
<Link
id={`${getSlugifiedText(name)}-blog-post-author-hero-section`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be blog-post/author-hero-section ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed this one, thanks. Actually id={${getSlugifiedText(name)}-author-avatar/hero-section/blog-post-page} looks better.

travjenkins
travjenkins previously approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - did not manually review every single one so assume you have updated them all to the new pattern

@Brenosalv
Copy link
Collaborator Author

Yes, I updated all of them to the new pattern.

travjenkins
travjenkins approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - merge looks good too!

@Brenosalv Brenosalv removed the generate-pr-preview Used to kick off a preview build for a PR label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travjenkins travjenkins travjenkins approved these changes

Assignees

@Brenosalv Brenosalv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IDs to all CTAs on the page
2 participants
@Brenosalv @travjenkins