.github: deployment automation for data-plane-controller and agent-api #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce workflow_dispatch actions for building and deploying these control-plane services to Cloud Run, using workload identity federation. Include Dockerfile infrastructure and entrypoints for placing secrets into exepected locations. Minor tweaks to data-plane-controller, adjusting defaults to work better with Cloud Run and also to support IPv4 addresses for Ansible hosts, which is required due to our dependency on Cloud Run (which only supports IPv4, paired with Cloud NAT).
mdibaiee
approved these changes
Nov 13, 2024
| @@ -0,0 +1,31 @@ | |||
| FROM ubuntu:noble | |||
There was a problem hiding this comment.
Does the image here affect our costs in any noticable way? I'm wondering if we could save costs by using a slimmer image. I guess it depends on how frequently this image is going to be run by Cloud Run and how much time is taken by the image to boot up compared to other images 🤔
| set -o nounset | ||
|
|
||
| # Place secrets into expected file locations. | ||
| mkdir /root/.aws |
There was a problem hiding this comment.
We are not placing anything here, is this actually necessary to create here manually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce workflow_dispatch actions for building and deploying these control-plane services to Cloud Run, using workload identity federation.
Include Dockerfile infrastructure and entrypoints for placing secrets into exepected locations.
Minor tweaks to data-plane-controller, adjusting defaults to work better with Cloud Run and also to support IPv4 addresses for Ansible hosts, which is required due to our dependency on Cloud Run (which only supports IPv4, paired with Cloud NAT).
Fixes #1767
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is