From b438c452bae2106f69568d43c0bd256f9e1b7080 Mon Sep 17 00:00:00 2001
From: Rob Pilling <robpilling@gmail.com>
Date: Sun, 31 Aug 2025 18:31:57 +0100
Subject: [PATCH 1/6] storageanalyzer: whitespace

---
 apps/storageanalyzer/custom.html | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/apps/storageanalyzer/custom.html b/apps/storageanalyzer/custom.html
index 2adefd29a6..56ce0581af 100644
--- a/apps/storageanalyzer/custom.html
+++ b/apps/storageanalyzer/custom.html
@@ -4,7 +4,7 @@
   </head>
   <body>
     <script src="../../core/lib/customize.js"></script>
-    <script type="text/javascript" src="https://www.gstatic.com/charts/loader.js"></script>    
+    <script type="text/javascript" src="https://www.gstatic.com/charts/loader.js"></script>
 
     <!-- Toggle Buttons -->
     <div class="btn-group" style="margin: 1em; display: flex; justify-content: center;">
@@ -24,7 +24,7 @@
     <script>
       let globalApps = [];
       let storageStats = null;
-      
+
       function onInit(device) {
         Util.showModal("Reading Storage...");
         Puck.eval(`(()=>{
@@ -120,7 +120,7 @@
 
           const totalOptions = {
             title: 'Total Storage Usage (KBs)',
-            
+
             chartArea: { width: '90%', height: '80%' },
             legend: { position: 'bottom' }
           };
@@ -131,7 +131,7 @@
       }
 
       google.charts.load('current', {'packages':['corechart']});
-      
+
 
       document.getElementById("pieChartButton").addEventListener("click", function () {
         document.getElementById("storageTable").style.display = "none";
@@ -148,7 +148,7 @@
         this.classList.add("btn-primary");
         document.getElementById("pieChartButton").classList.remove("btn-primary");
       });
-      
+
     </script>
   </body>
 </html>

From d0d89897afd835373b2357525aa55516ce3a7cc8 Mon Sep 17 00:00:00 2001
From: Rob Pilling <robpilling@gmail.com>
Date: Sun, 31 Aug 2025 18:32:39 +0100
Subject: [PATCH 2/6] storageanalyzer: handle error conditions, alter parsing
 of `info.data`

---
 apps/storageanalyzer/custom.html | 122 +++++++++++++++++++++++--------
 1 file changed, 90 insertions(+), 32 deletions(-)

diff --git a/apps/storageanalyzer/custom.html b/apps/storageanalyzer/custom.html
index 56ce0581af..3db4973475 100644
--- a/apps/storageanalyzer/custom.html
+++ b/apps/storageanalyzer/custom.html
@@ -1,6 +1,11 @@
 <html>
   <head>
     <link rel="stylesheet" href="../../css/spectre.min.css">
+    <style>
+      #errors {
+        overflow: scroll;
+      }
+    </style>
   </head>
   <body>
     <script src="../../core/lib/customize.js"></script>
@@ -21,45 +26,98 @@
       <div id="totalStoragePie" style="width: 100%; max-width: 600px; height: 300px;"></div>
     </div>
 
+    <pre id="errors"></pre>
+
     <script>
       let globalApps = [];
       let storageStats = null;
 
       function onInit(device) {
         Util.showModal("Reading Storage...");
-        Puck.eval(`(()=>{
-          let getApps = () => require("Storage").list(/\\.info$/).map(appInfoName => {
-            let appInfo = require("Storage").readJSON(appInfoName,1)||{};
-            var fileSize = 0, dataSize = 0;
-            appInfo.files.split(",").forEach(f => fileSize += require("Storage").read(f).length);
-            var data = (appInfo.data||"").split(";");
-            function wildcardToRegexp(wc) {
-              return new RegExp("^"+wc.replaceAll(".","\\\\.").replaceAll("?",".*")+"$");
+        Puck.eval(`
+          (()=>{
+            const output = {
+              stats: require("Storage").getStats(),
+              apps: [],
+              errors: [],
+            };
+
+            require("Storage")
+              .list(/\.info$/)
+              .forEach(appInfoName => {
+                try{
+                  let appInfo = require("Storage").readJSON(appInfoName, 1);
+
+                  if(appInfo == null){
+                    /* should never happen, since we just got the filename from list() */
+                    output.errors.push({ app: appInfoName, err: "no info file" });
+                    return null;
+                  }
+
+                  const fileSize = f => (require("Storage").read(f) || "").length;
+                  let fileTotal = 0;
+
+                  if(appInfo.files)
+                    appInfo.files
+                      .split(",")
+                      .forEach(f => fileTotal += fileSize(f));
+
+                  function wildcardToRegexp(wc) {
+                    return new RegExp("^"+wc.replaceAll(".","\\.").replaceAll("?",".*")+"$");
+                  }
+
+                  let dataSize = 0;
+
+                  if(appInfo.data){
+                    const sum = (a, b) => a + b;
+                    const sumFiles = (patterns, options) => (
+                        patterns
+                        .map(pattern =>
+                            require("Storage")
+                                .list(wildcardToRegexp(pattern), options)
+                                .map(fileSize)
+                                .reduce(sum, 0)
+                        )
+                        .reduce(sum, 0)
+                    );
+
+                    /* parse the datastring, see core/js/appinfo.js, makeDataString */
+                    const fileObj = appInfo.data.split(";").map(d => d.split(","));
+                    const files = fileObj[0];
+                    const storage = fileObj[1];
+                    if (files == null || (files.length === 1 && files[0] === "")) files = [];
+
+                    dataSize = sumFiles(files, {sf: false}) + sumFiles(storage || [], {sf: true});
+                  }
+
+                  output.apps.push([appInfo.id, fileTotal, dataSize]);
+                }catch(e){
+                  output.errors.push({ app: appInfoName, err: "" + e });
+                }
+              })
+
+            return output;
+          })()
+        `,
+          function({ apps, stats, errors}) {
+            Util.hideModal();
+            globalApps = apps.sort((a,b) => (b[1]+b[2]) - (a[1]+a[2]));
+            storageStats = stats;
+
+            if(errors.length){
+              document.getElementById("errors").innerText = errors
+                .map(({ app, err }) => `Error in app "${app}": ${err}`)
+                .join("\n");
             }
-            if (data[0]) data[0].split(",").forEach(wc => {
-              require("Storage").list(wildcardToRegexp(wc), {sf:false}).forEach(f => {
-                dataSize += require("Storage").read(f).length
-              });
-            });
-            if (data[1]) data[1].split(",").forEach(wc => {
-              require("Storage").list(wildcardToRegexp(wc), {sf:true}).forEach(f => {
-                dataSize += require("Storage").open(f,"r").getLength();
-              });
-            });
-            return [appInfo.id, fileSize, dataSize];
-          });
-          return [getApps(), require(\"Storage\").getStats()]; })()`, function(result) {
-          Util.hideModal();
-          globalApps = result[0].sort((a,b) => (b[1]+b[2]) - (a[1]+a[2]));
-          storageStats = result[1];
-
-          if (globalApps.length === 0) {
-            document.getElementById("storageTable").innerHTML = "<p>No apps found</p>";
-            return;
-          }
-
-          drawTable();
-        });
+
+            if (globalApps.length === 0) {
+              document.getElementById("storageTable").innerHTML = "<p>No apps found</p>";
+              return;
+            }
+
+            drawTable();
+          },
+        );
       }
       function roundDecimal(num){
         return Math.round(num * 10) / 10;

From 96323600e90dfa0ef60dd603566c62709e2b3cf9 Mon Sep 17 00:00:00 2001
From: Rob Pilling <robpilling@gmail.com>
Date: Sun, 31 Aug 2025 18:33:08 +0100
Subject: [PATCH 3/6] storageanalyzer: bump version

---
 apps/storageanalyzer/ChangeLog     | 1 +
 apps/storageanalyzer/metadata.json | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/apps/storageanalyzer/ChangeLog b/apps/storageanalyzer/ChangeLog
index d2dcee1107..02b8f2c91c 100644
--- a/apps/storageanalyzer/ChangeLog
+++ b/apps/storageanalyzer/ChangeLog
@@ -1,3 +1,4 @@
 0.01: New App!
 0.02: Added pie chart for visualization, tweaked UI.
 0.03: Fixed bug with total storage pie chart.
+0.04: Fixed bug with data parsing.
diff --git a/apps/storageanalyzer/metadata.json b/apps/storageanalyzer/metadata.json
index 902f93b06b..c3f7f7eee0 100644
--- a/apps/storageanalyzer/metadata.json
+++ b/apps/storageanalyzer/metadata.json
@@ -1,7 +1,7 @@
 {
   "id": "storageanalyzer",
   "name": "Storage Analyzer",
-  "version": "0.03",
+  "version": "0.04",
   "description": "Analyzes Bangle.js storage and shows which apps are using storage space",
   "icon": "icon.png",
   "type": "RAM",

From 5db1ca0b2b547b8e2151feda19fba17fe96351f1 Mon Sep 17 00:00:00 2001
From: Rob Pilling <robpilling@gmail.com>
Date: Mon, 1 Sep 2025 21:26:39 +0100
Subject: [PATCH 4/6] storageanalyzer: split up large `puckEval()`

---
 apps/storageanalyzer/custom.html | 167 +++++++++++++++----------------
 1 file changed, 81 insertions(+), 86 deletions(-)

diff --git a/apps/storageanalyzer/custom.html b/apps/storageanalyzer/custom.html
index 3db4973475..4f1929e7f1 100644
--- a/apps/storageanalyzer/custom.html
+++ b/apps/storageanalyzer/custom.html
@@ -32,92 +32,87 @@
       let globalApps = [];
       let storageStats = null;
 
-      function onInit(device) {
+      async function onInit(device) {
+        const puckRequest = js => new Promise(resolve => Puck.eval(js, resolve));
+        const wildcardToRegexp = wc => new RegExp("^" + wc.replaceAll(".", "\\.").replaceAll("?", ".*") + "$");
+        const fileSize = async f => await puckRequest(`(require("Storage").read("${f}") || "").length`);
+        const sum = (a, b) => a + b;
+
         Util.showModal("Reading Storage...");
-        Puck.eval(`
-          (()=>{
-            const output = {
-              stats: require("Storage").getStats(),
-              apps: [],
-              errors: [],
-            };
-
-            require("Storage")
-              .list(/\.info$/)
-              .forEach(appInfoName => {
-                try{
-                  let appInfo = require("Storage").readJSON(appInfoName, 1);
-
-                  if(appInfo == null){
-                    /* should never happen, since we just got the filename from list() */
-                    output.errors.push({ app: appInfoName, err: "no info file" });
-                    return null;
-                  }
-
-                  const fileSize = f => (require("Storage").read(f) || "").length;
-                  let fileTotal = 0;
-
-                  if(appInfo.files)
-                    appInfo.files
-                      .split(",")
-                      .forEach(f => fileTotal += fileSize(f));
-
-                  function wildcardToRegexp(wc) {
-                    return new RegExp("^"+wc.replaceAll(".","\\.").replaceAll("?",".*")+"$");
-                  }
-
-                  let dataSize = 0;
-
-                  if(appInfo.data){
-                    const sum = (a, b) => a + b;
-                    const sumFiles = (patterns, options) => (
-                        patterns
-                        .map(pattern =>
-                            require("Storage")
-                                .list(wildcardToRegexp(pattern), options)
-                                .map(fileSize)
-                                .reduce(sum, 0)
-                        )
-                        .reduce(sum, 0)
-                    );
-
-                    /* parse the datastring, see core/js/appinfo.js, makeDataString */
-                    const fileObj = appInfo.data.split(";").map(d => d.split(","));
-                    const files = fileObj[0];
-                    const storage = fileObj[1];
-                    if (files == null || (files.length === 1 && files[0] === "")) files = [];
-
-                    dataSize = sumFiles(files, {sf: false}) + sumFiles(storage || [], {sf: true});
-                  }
-
-                  output.apps.push([appInfo.id, fileTotal, dataSize]);
-                }catch(e){
-                  output.errors.push({ app: appInfoName, err: "" + e });
+
+        const apps = [];
+        let stats;
+        const errors = [];
+        try{
+          stats = await puckRequest('require("Storage").getStats()');
+
+          const infos = await puckRequest('require("Storage").list(/\\.info$/)');
+
+          for(const appInfoName of infos){
+            try{
+              const appInfo = await puckRequest(`require("Storage").readJSON("${appInfoName}", 1)`);
+
+              if(appInfo == null){
+                errors.push({ app: appInfoName, err: "no info file" });
+                continue;
+              }
+
+              let fileTotal = 0;
+
+              if(appInfo.files){
+                for(const f of appInfo.files.split(",")){
+                  fileTotal += await fileSize(f);
                 }
-              })
-
-            return output;
-          })()
-        `,
-          function({ apps, stats, errors}) {
-            Util.hideModal();
-            globalApps = apps.sort((a,b) => (b[1]+b[2]) - (a[1]+a[2]));
-            storageStats = stats;
-
-            if(errors.length){
-              document.getElementById("errors").innerText = errors
-                .map(({ app, err }) => `Error in app "${app}": ${err}`)
-                .join("\n");
+              }
+
+              let dataSize = 0;
+
+              if(appInfo.data){
+                const sumFiles = async (patterns, options) => (
+                  (await Promise.all(
+                    patterns
+                    .map(async pattern => {
+                      const names = await puckRequest(`require("Storage").list(${wildcardToRegexp(pattern)}, ${JSON.stringify(options)})`);
+
+                      return (await Promise.all(names.map(fileSize))).reduce(sum, 0)
+                    })
+                  ))
+                  .reduce(sum, 0)
+                );
+
+                /* parse the datastring, see core/js/appinfo.js, makeDataString */
+                const fileObj = appInfo.data.split(";").map(d => d.split(","));
+                const files = fileObj[0];
+                const storage = fileObj[1];
+                if (files == null || (files.length === 1 && files[0] === "")) files = [];
+
+                dataSize = await sumFiles(files, {sf: false}) + await sumFiles(storage || [], {sf: true});
+              }
+
+              apps.push({ id: appInfo.id, fileSize: fileTotal, dataSize });
+            }catch(e){
+              errors.push({ app: appInfoName, err: "" + e });
             }
+          }
+        }finally{
+          Util.hideModal();
+        }
 
-            if (globalApps.length === 0) {
-              document.getElementById("storageTable").innerHTML = "<p>No apps found</p>";
-              return;
-            }
+        globalApps = apps.sort((a,b) => (b.fileSize + b.dataSize) - (a.fileSize + a.dataSize));
+        storageStats = stats;
+
+        if(errors.length){
+          document.getElementById("errors").innerText = errors
+            .map(({ app, err }) => `Error in app "${app}": ${err}`)
+            .join("\n");
+        }
 
-            drawTable();
-          },
-        );
+        if (globalApps.length === 0) {
+          document.getElementById("storageTable").innerHTML = "<p>No apps found</p>";
+          return;
+        }
+
+        drawTable();
       }
       function roundDecimal(num){
         return Math.round(num * 10) / 10;
@@ -136,10 +131,10 @@
             <tbody>
               ${globalApps.map(app => `
                 <tr>
-                  <td>${app[0]}</td>
-                  <td>${(app[1]/1000).toFixed(1)}</td>
-                  <td>${(app[2]/1000).toFixed(1)}</td>
-                  <td>${((app[1]+app[2])/1000).toFixed(1)}</td>
+                  <td>${app.id}</td>
+                  <td>${(app.fileSize/1000).toFixed(1)}</td>
+                  <td>${(app.dataSize/1000).toFixed(1)}</td>
+                  <td>${((app.fileSize+app.dataSize)/1000).toFixed(1)}</td>
                 </tr>`).join("")}
             </tbody>
           </table>`;
@@ -151,7 +146,7 @@
         // App-specific chart
         const chartData = [
           ['App', 'Total Size (KB)']
-        ].concat(globalApps.map(app => [app[0], roundDecimal((app[1] + app[2])/1000)]));
+        ].concat(globalApps.map(app => [app.id, roundDecimal((app.fileSize + app.dataSize)/1000)]));
 
         const data = google.visualization.arrayToDataTable(chartData);
 

From 8bbb1d7c8b31f0b840eb3052ff102037a1add2bd Mon Sep 17 00:00:00 2001
From: Rob Pilling <robpilling@gmail.com>
Date: Mon, 1 Sep 2025 21:33:34 +0100
Subject: [PATCH 5/6] storageanalyzer: hide error `<pre>` when there are no
 errors

---
 apps/storageanalyzer/custom.html | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/apps/storageanalyzer/custom.html b/apps/storageanalyzer/custom.html
index 4f1929e7f1..0111a60fd4 100644
--- a/apps/storageanalyzer/custom.html
+++ b/apps/storageanalyzer/custom.html
@@ -101,8 +101,10 @@
         globalApps = apps.sort((a,b) => (b.fileSize + b.dataSize) - (a.fileSize + a.dataSize));
         storageStats = stats;
 
+        const errorEl = document.getElementById("errors");
+        errorEl.classList.toggle("d-hide", errors.length === 0);
         if(errors.length){
-          document.getElementById("errors").innerText = errors
+          errorEl.innerText = errors
             .map(({ app, err }) => `Error in app "${app}": ${err}`)
             .join("\n");
         }

From 717d0b016d45996a01f44cd6eb859a8985654464 Mon Sep 17 00:00:00 2001
From: Rob Pilling <robpilling@gmail.com>
Date: Tue, 2 Sep 2025 07:50:05 +0100
Subject: [PATCH 6/6] storageanalyzer: make `files` a `let`

---
 apps/storageanalyzer/custom.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/storageanalyzer/custom.html b/apps/storageanalyzer/custom.html
index 0111a60fd4..004ed20314 100644
--- a/apps/storageanalyzer/custom.html
+++ b/apps/storageanalyzer/custom.html
@@ -82,7 +82,7 @@
 
                 /* parse the datastring, see core/js/appinfo.js, makeDataString */
                 const fileObj = appInfo.data.split(";").map(d => d.split(","));
-                const files = fileObj[0];
+                let files = fileObj[0];
                 const storage = fileObj[1];
                 if (files == null || (files.length === 1 && files[0] === "")) files = [];
 
