LEDC: Remove old ESP32 GPIO list of available pins#6635
Conversation
The docs still listed an original ESP32 era list of GPIO-Pins: 'GPIO0-GPIO33' Instead reference just that the pin must be an output pin, as there's no more detailed documentation of the pins available in the docs right now.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request updates the LEDC output component documentation to clarify that the pin configuration requires an output pin, replacing the prior GPIO0–GPIO33 restriction. ChangesLEDC pin configuration documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@guillempages thanks for the review! Can you please have a look at the other 3 PRs I made for the page? |
Description
The docs still listed an original ESP32 era list of GPIO-Pins: 'GPIO0-GPIO33'
Instead reference just that the pin must be an output pin, as there's no more detailed documentation of the pins available in the docs right now.
Checklist
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.