Skip to content

LEDC: Remove old ESP32 GPIO list of available pins#6635

Merged
guillempages merged 2 commits into
esphome:currentfrom
RubenKelevra:ledc_gpio_pin_wording_docs
May 30, 2026
Merged

LEDC: Remove old ESP32 GPIO list of available pins#6635
guillempages merged 2 commits into
esphome:currentfrom
RubenKelevra:ledc_gpio_pin_wording_docs

Conversation

@RubenKelevra
Copy link
Copy Markdown
Contributor

Description

The docs still listed an original ESP32 era list of GPIO-Pins: 'GPIO0-GPIO33'

Instead reference just that the pin must be an output pin, as there's no more detailed documentation of the pins available in the docs right now.

Checklist

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

The docs still listed an original ESP32 era list of GPIO-Pins:
'GPIO0-GPIO33'

Instead reference just that the pin must be an output pin, as there's no
more detailed documentation of the pins available in the docs right now.
@esphome esphome Bot added the current label May 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bee8a741-d174-4278-acba-6e38ece1f93a

📥 Commits

Reviewing files that changed from the base of the PR and between f33636d and a360054.

📒 Files selected for processing (1)
  • src/content/docs/components/output/ledc.mdx

Walkthrough

The pull request updates the LEDC output component documentation to clarify that the pin configuration requires an output pin, replacing the prior GPIO0–GPIO33 restriction.

Changes

LEDC pin configuration documentation

Layer / File(s) Summary
Pin configuration description
src/content/docs/components/output/ledc.mdx
Updated the pin configuration requirement to specify that the pin must be an output pin, removing the previous GPIO0–GPIO33 range constraint.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

current

Suggested reviewers

  • swoboda1337
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing outdated ESP32 GPIO pin list (GPIO0-GPIO33) from LEDC documentation.
Description check ✅ Passed The description clearly explains the motivation for the change: replacing an outdated GPIO pin list with a more generic requirement that the pin must be an output pin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 16, 2026

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit c45f9e3
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/6a1a75812e3f3e0009618c3b
😎 Deploy Preview https://deploy-preview-6635--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@guillempages guillempages enabled auto-merge (squash) May 30, 2026 05:28
@guillempages guillempages merged commit 7a1b090 into esphome:current May 30, 2026
6 checks passed
@RubenKelevra
Copy link
Copy Markdown
Contributor Author

@guillempages thanks for the review!

Can you please have a look at the other 3 PRs I made for the page?

@RubenKelevra RubenKelevra deleted the ledc_gpio_pin_wording_docs branch May 30, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants