Skip to content

Conversation

@miniskipper
Copy link

@miniskipper miniskipper commented Nov 25, 2025

Description:

Add M5Stack-Tab5-V2 model

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable):

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/index.rst when creating new documents for new components or cookbook.

New Component Images

If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.

To generate a component image:

  1. Comment on this pull request with the following command, replacing COMPONENT_NAME with your component name in UPPER_CASE format with underscores (e.g., BME280, SHT3X, DALLAS_TEMP):

    @esphomebot generate image COMPONENT_NAME
    
  2. The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.

  3. Extract the SVG file and place it in the images/ folder of this repository.

  4. Use the image in your component's index table entry in /components/index.rst.

Example: For a component called "DHT22 Temperature Sensor", use:

@esphomebot generate image DHT22

ngraziano and others added 2 commits November 24, 2025 22:45
The conversion from optional<bool> to bool return always true, it is needed to call the value member.

Co-authored-by: Jonathan Swoboda <[email protected]>
esphome[bot]
esphome bot previously requested changes Nov 25, 2025
Copy link

@esphome esphome bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.

@esphome esphome bot marked this pull request as draft November 25, 2025 10:36
@esphome
Copy link

esphome bot commented Nov 25, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 509f294
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/6927e1c8cdae8f0008417feb
😎 Deploy Preview https://deploy-preview-5677--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Walkthrough

A new board entry (M5STACK-TAB5-V2) was added to the MIPI DSI display compatibility table in the documentation, referencing the same manufacturer and product URL as an existing variant.

Changes

Cohort / File(s) Summary
Documentation update
content/components/display/mipi_dsi.md
Added M5STACK-TAB5-V2 entry to the "Boards with integrated displays" table with matching manufacturer and product URL as M5STACK-TAB5

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

has-parent, current

Suggested reviewers

  • clydebarrow
  • nagyrobi

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding M5Stack-Tab5-V2 model to the mipi_dsi documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes adding the M5Stack-Tab5-V2 model to the mipi_dsi documentation with a reference to the matching esphome repository PR #12074.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@miniskipper miniskipper changed the base branch from current to next November 26, 2025 09:58
@esphome esphome bot added the next label Nov 26, 2025
@esphome esphome bot dismissed their stale review November 26, 2025 09:58

Base branch has been corrected - dismissing previous review.

@miniskipper miniskipper marked this pull request as ready for review November 27, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants