Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the "needs info" message depending on the other labels #62

Open
not-an-aardvark opened this issue Feb 6, 2018 · 3 comments
Open

Comments

@not-an-aardvark
Copy link
Member

When someone adds the needs info label, the bot's message is intentionally very generic, because we sometimes aren't sure what an issue is trying to do at all. However, there are other cases where the type of an issue is clear, but not enough information has been provided to respond to it (e.g. if the issue is proposing a new behavior but is insufficiently detailed about what the new behavior is). In these cases, the generic "needs info" message isn't as applicable.

It would be nice if the bot looked at the other labels on the issue, and gave a specialized message. For example, if enhancement, rule, and needs info were added at the same time, the bot would ask the user to fill out the rule change proposal template. If bug and needs info were added at the same time, the bot would ask the user to fill out the bug report template.

@platinumazure
Copy link
Member

Question: Should the bot be agile enough to edit its own message as the labels change? (e.g., if we started with triage/needs info and then edited to be bug/evaluating/needs info, it could edit its previous message with the bug report template)

@not-an-aardvark
Copy link
Member Author

I suppose that would be nice, although it's probably not required for the plugin to be useful if it would be easier to implement without that feature.

@kaicataldo
Copy link
Member

I wonder if it being "dumber" is actually better in this case - i.e. it creates a new comment with the relevant information whenever the "needs info" label is added based on whatever labels it has at that moment. I think it'll make easier to understand for those viewing the conversation after the fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants