-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-aware configs #445
Comments
I'm leaning toward a single Thoughts? |
Curiosity: what was the motivation for making standalone |
I'll have to look back at the PRs that added those configs to see if there was any explanation mentioned for adding them. However, they are theoretically useful for reducing false positives so we don't mistakenly detect rules or tests in files they shouldn't exist in, and for performance (although this isn't a huge concern in eslint plugins which are usually small). Either way, I do think it's important to have a solution that can scale regardless of how many configs we have. There are many possible conceivable configs including for stylistic preferences, targeting older versions, etc. In general, I think there should be a convention for type-aware rule configs that handles plugins with a variety or larger number of configs without causing excess maintenance burden or unnecessarily multiplying the API surface. |
Perhaps we could introduce The final exported configs can be derived by calculating various combinations of
The idea originally came from my vision for the rules presentation on the eslint website. The benefit of this approach is that it is highly scalable. |
Continuing this discussion:
Originally posted by @JoshuaKGoldberg in #433 (comment)
The text was updated successfully, but these errors were encountered: