Fix: handle spreads in rule meta objects (#100)

Author: bradzacher

lib/utils.js

@@ -184,6 +184,10 @@ module.exports = {
   * @returns {string|null} The key name, or `null` if the name cannot be determined statically.
   */
   getKeyName (property) {
+    if (!property.key) {
+      // likely a SpreadElement or another non-standard node
+      return null;
+    }
     if (!property.computed && property.key.type === 'Identifier') {
       return property.key.name;
     }

tests/lib/rules/require-meta-fixable.js

@@ -105,6 +105,19 @@ ruleTester.run('require-meta-fixable', rule, {
         create(context) { context.report(node, message, data, fix); }
       };
     `,
+    {
+      code: `
+        const meta = {};
+        module.exports = {
+          ...meta,
+          meta: {},
+          create(context) { context.report(node, message, data, fix); }
+        };
+      `,
+      parserOptions: {
+        ecmaVersion: 9,
+      },
+    },
   ],
 
   invalid: [

tests/lib/utils.js

@@ -183,6 +183,17 @@ describe('utils', () => {
         assert.strictEqual(utils.getKeyName(ast.body[0].expression.properties[0]), CASES[objectSource]);
       });
     });
+
+    const CASES_ES9 = {
+      '({ ...foo })': null,
+    };
+    Object.keys(CASES_ES9).forEach(objectSource => {
+      it(objectSource, () => {
+        const ast = espree.parse(objectSource, { ecmaVersion: 9 });
+
+        assert.strictEqual(utils.getKeyName(ast.body[0].expression.properties[0]), CASES_ES9[objectSource]);
+      });
+    });
   });
 
   describe('getTestInfo', () => {