Crash in mod_vcard.erl when user try set special chars

[vkatsuba]

MongooseIM version: 3.3.0
Installed from: https://github.com/esl/MongooseIM/tree/3.3.0
Erlang/OTP version: 20

Hi All,

When user try set nickname with special chars like 😊 - the mod_vcard.erl is crashed by reason that inside of mod_vcard.erl is used stringprep:tolower/1, and stringprep:tolower/1 will return atom error for binaries eg: <<240,159,152,138>>. The binary_to_list/1 don't working with atoms, maybe make sense use cowboy_bstr:to_lower/1 instead of stringprep:tolower/1?

cowboy_bstr:to_lower(<<"ABC">>) =:= stringprep:tolower(<<"ABC">>).
true

cowboy_bstr:to_lower(<<240,159,152,138>>).
<<240,159,152,138>>

stringprep:tolower(<<240,159,152,138>>).
error

P.S. I was created ticket about this issue for stringprep - processone/stringprep#9

Cheers!

[fenek]

Hi @vkatsuba

Let me clarify first - so the problem affects one of vCard fields you're trying to set, right?

[vkatsuba]

Hi @fenek,

I suppose this can be affects all fields vCard where we can try set special chars and the places where used stringprep:tolower/1

[fenek]

This problem may actually manifest in more places in MIM code. You are right, that it should be improved. I have created an internal ticket to fix this issue.

[vkatsuba]

Hi @fenek, thanks for response

[fenek]

The issue is resolved in the current master.