Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate walletconnect to use URLSearchParams #10

Open
43081j opened this issue Jan 27, 2024 · 3 comments
Open

migrate walletconnect to use URLSearchParams #10

43081j opened this issue Jan 27, 2024 · 3 comments
Labels
accepts prs The maintainer of the target repo was contacted and welcomes prs has pr This issue has a corresponding PR in the target repo

Comments

@43081j
Copy link
Collaborator

43081j commented Jan 27, 2024

The walletconnect monorepo can be found here:
https://github.com/WalletConnect/walletconnect-monorepo/

The utils package can be found here:
https://github.com/WalletConnect/walletconnect-monorepo/blob/v2.0/packages/utils/

We should migrate to using URLSearchParams instead of the query-string package.

There is no node constraint as far as i can tell, so we should note we will be introducing one with this change.

if nesting is required, we should use fast-querystring or nested-querystring

@Fuzzyma
Copy link
Collaborator

Fuzzyma commented Dec 18, 2024

@talentlessguy were you able to marge the prs? I cant find them linked. If so, we can close this issue

@talentlessguy
Copy link

@Fuzzyma nah i closed the pr but havent' opened a new one yet

@Fuzzyma Fuzzyma added accepts prs The maintainer of the target repo was contacted and welcomes prs and removed help wanted Extra attention is needed labels Dec 18, 2024
@talentlessguy
Copy link

WalletConnect/walletconnect-monorepo#5576 new PR

@Fuzzyma Fuzzyma added the has pr This issue has a corresponding PR in the target repo label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepts prs The maintainer of the target repo was contacted and welcomes prs has pr This issue has a corresponding PR in the target repo
Projects
None yet
Development

No branches or pull requests

3 participants